Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Unified Diff: chrome/browser/printing/cloud_print/cloud_print_proxy_service.h

Issue 575993002: Fix WeakPtrFactory member ordering in chrome/browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/cloud_print/cloud_print_proxy_service.h
diff --git a/chrome/browser/printing/cloud_print/cloud_print_proxy_service.h b/chrome/browser/printing/cloud_print/cloud_print_proxy_service.h
index 7155015a458f550856dd914c5c601b3de4e7e84a..cef60be929c5823feae018bf5a452ab914115a9a 100644
--- a/chrome/browser/printing/cloud_print/cloud_print_proxy_service.h
+++ b/chrome/browser/printing/cloud_print/cloud_print_proxy_service.h
@@ -96,8 +96,6 @@ class CloudPrintProxyService : public KeyedService {
// Virtual for testing.
virtual ServiceProcessControl* GetServiceProcessControl();
- base::WeakPtrFactory<CloudPrintProxyService> weak_factory_;
-
// For watching for connector policy changes.
PrefChangeRegistrar pref_change_registrar_;
@@ -105,6 +103,8 @@ class CloudPrintProxyService : public KeyedService {
// once successful.
bool enforcing_connector_policy_;
+ base::WeakPtrFactory<CloudPrintProxyService> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(CloudPrintProxyService);
};

Powered by Google App Engine
This is Rietveld 408576698