chrome/browser/policy/cloud/cloud_policy_invalidator.h - Issue 575993002: Fix WeakPtrFactory member ordering in chrome/browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/cloud/cloud_policy_invalidator.h

Issue 575993002: Fix WeakPtrFactory member ordering in chrome/browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/chrome_password_manager_client.cc ('k') | chrome/browser/policy/cloud/cloud_policy_invalidator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/cloud/cloud_policy_invalidator.h

diff --git a/chrome/browser/policy/cloud/cloud_policy_invalidator.h b/chrome/browser/policy/cloud/cloud_policy_invalidator.h

index 7033c138dafb3b854d75202d74950af5ee61c3f5..d5a6ba7a9a1abdc6e1eafd2bf1b8fee576dd9d2e 100644

--- a/chrome/browser/policy/cloud/cloud_policy_invalidator.h

+++ b/chrome/browser/policy/cloud/cloud_policy_invalidator.h

@@ -221,9 +221,6 @@ class CloudPolicyInvalidator : public syncer::InvalidationHandler,

// The most up to date invalidation.

scoped_ptr<syncer::Invalidation> invalidation_;

- // WeakPtrFactory used to create callbacks to this object.

- base::WeakPtrFactory<CloudPolicyInvalidator> weak_factory_;

// The maximum random delay, in ms, between receiving an invalidation and

// fetching the new policy.

int max_fetch_delay_;

@@ -236,6 +233,9 @@ class CloudPolicyInvalidator : public syncer::InvalidationHandler,

// thread.

base::ThreadChecker thread_checker_;

+ // WeakPtrFactory used to create callbacks to this object.

+ base::WeakPtrFactory<CloudPolicyInvalidator> weak_factory_;

DISALLOW_COPY_AND_ASSIGN(CloudPolicyInvalidator);

};