Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7221)

Unified Diff: chrome/browser/history/history_service.cc

Issue 575993002: Fix WeakPtrFactory member ordering in chrome/browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_service.h ('k') | chrome/browser/io_thread.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_service.cc
diff --git a/chrome/browser/history/history_service.cc b/chrome/browser/history/history_service.cc
index 0ab7a9f10e67119c1fb5c309d2c31c74e6c5868e..fd4c2d90a380fbcc609261e8f545eb6c0f5c8d1f 100644
--- a/chrome/browser/history/history_service.cc
+++ b/chrome/browser/history/history_service.cc
@@ -206,23 +206,23 @@ class HistoryService::BackendDelegate : public HistoryBackend::Delegate {
// sync integration unit tests depend on being able to create more than one
// history thread.
HistoryService::HistoryService()
- : weak_ptr_factory_(this),
- thread_(new base::Thread(kHistoryThreadName)),
+ : thread_(new base::Thread(kHistoryThreadName)),
history_client_(NULL),
profile_(NULL),
backend_loaded_(false),
- no_db_(false) {
+ no_db_(false),
+ weak_ptr_factory_(this) {
}
HistoryService::HistoryService(history::HistoryClient* client, Profile* profile)
- : weak_ptr_factory_(this),
- thread_(new base::Thread(kHistoryThreadName)),
+ : thread_(new base::Thread(kHistoryThreadName)),
history_client_(client),
profile_(profile),
visitedlink_master_(new visitedlink::VisitedLinkMaster(
profile, this, true)),
backend_loaded_(false),
- no_db_(false) {
+ no_db_(false),
+ weak_ptr_factory_(this) {
DCHECK(profile_);
registrar_.Add(this, chrome::NOTIFICATION_HISTORY_URLS_DELETED,
content::Source<Profile>(profile_));
« no previous file with comments | « chrome/browser/history/history_service.h ('k') | chrome/browser/io_thread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698