Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: chrome/browser/history/expire_history_backend.h

Issue 575993002: Fix WeakPtrFactory member ordering in chrome/browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/expire_history_backend.h
diff --git a/chrome/browser/history/expire_history_backend.h b/chrome/browser/history/expire_history_backend.h
index fdabd77095b98a74d9c88fe51d03113dfb6405eb..3cb8e806ef83304067c3335e275d3a51a1270191 100644
--- a/chrome/browser/history/expire_history_backend.h
+++ b/chrome/browser/history/expire_history_backend.h
@@ -253,10 +253,6 @@ class ExpireHistoryBackend {
HistoryDatabase* main_db_; // Main history database.
ThumbnailDatabase* thumb_db_; // Thumbnails and favicons.
- // Used to generate runnable methods to do timers on this class. They will be
- // automatically canceled when this class is deleted.
- base::WeakPtrFactory<ExpireHistoryBackend> weak_factory_;
-
// The threshold for "old" history where we will automatically delete it.
base::TimeDelta expiration_threshold_;
@@ -281,6 +277,10 @@ class ExpireHistoryBackend {
// loaded before returning.
HistoryClient* history_client_;
+ // Used to generate runnable methods to do timers on this class. They will be
+ // automatically canceled when this class is deleted.
+ base::WeakPtrFactory<ExpireHistoryBackend> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(ExpireHistoryBackend);
};
« no previous file with comments | « chrome/browser/content_settings/permission_context_base.h ('k') | chrome/browser/history/expire_history_backend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698