Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1268)

Unified Diff: chrome/browser/jumplist_win.h

Issue 575993002: Fix WeakPtrFactory member ordering in chrome/browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/io_thread.cc ('k') | chrome/browser/jumplist_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/jumplist_win.h
diff --git a/chrome/browser/jumplist_win.h b/chrome/browser/jumplist_win.h
index 41b12a939285b2555e617f208d2b022610defd44..58dd7f12a14bea9d71b66d401c0cf233896e2f02 100644
--- a/chrome/browser/jumplist_win.h
+++ b/chrome/browser/jumplist_win.h
@@ -134,9 +134,6 @@ class JumpList : public TabRestoreServiceObserver,
// loaded icons.
void CreateIconFiles(const ShellLinkItemList& item_list);
- // For callbacks may be run after destruction.
- base::WeakPtrFactory<JumpList> weak_ptr_factory_;
-
// Tracks FaviconService tasks.
base::CancelableTaskTracker cancelable_task_tracker_;
@@ -174,6 +171,9 @@ class JumpList : public TabRestoreServiceObserver,
// as they may be used by up to 3 threads.
base::Lock list_lock_;
+ // For callbacks may be run after destruction.
+ base::WeakPtrFactory<JumpList> weak_ptr_factory_;
+
DISALLOW_COPY_AND_ASSIGN(JumpList);
};
« no previous file with comments | « chrome/browser/io_thread.cc ('k') | chrome/browser/jumplist_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698