Move PageTransition from //content/public/common to //ui/base

Move PageTransition from //content/public/common to //ui/base

Move PageTransition enumeration from //content/public/common to //ui/base
so that it can be used by iOS and layered components that are used on iOS.

BUG=372373
R=avi@chromium.org, ben@chromium.org, wfh@chromium.org
TBR=ben, nasko

Committed: https://chromium.googlesource.com/chromium/src/+/c6ccc77dc9c080d83e400dc12205bb805a25ac71

[sdefresne, 2014-09-10 15:21:16]

sdefresne@chromium.org changed reviewers:
+ beng@chromium.org, jam@chromium.org

[sdefresne, 2014-09-10 16:24:20]

sdefresne@chromium.org changed reviewers:
+ ben.yan@msn.com
- beng@chromium.org

[sdefresne, 2014-09-10 16:24:50]

sdefresne@chromium.org changed reviewers:
+ ben@chromium.org
- ben.yan@msn.com

[sdefresne, 2014-09-10 16:27:59]

sdefresne@chromium.org changed reviewers:
+ nasko@chromium.org

[sdefresne, 2014-09-10 16:28:41]

sdefresne@chromium.org changed reviewers:
- nasko@chromium.org

[sdefresne, 2014-09-10 16:37:36]

Hello John, Ben, Brett,

If I understand correctly, you agreed Monday to move the PageTransition
enumeration from //content to //ui/base. This CL implements this.

Sorry for the size of the CL but I didn't find a way to do the change in
multiple CLs. You can check the first patch that does the move and change the
namespace. It has a manageable size.

The second CL was done using tools/git/mffr.py to rename
content::(PageTransition|PAGE_TRANSITION)* to
ui::(PageTransition|PAGE_TRANSITION)* and reformating. Subsequent CLs fix some
compilation errors after rebasing.

jam@ could you take a look at //content/public?
ben@ could you take a look at //ui/base?
brettw@ no need to take a look, just FYI

Regards,

[jam, 2014-09-12 04:22:35]

jam@chromium.org changed reviewers:
+ avi@chromium.org

[jam, 2014-09-12 04:22:38]

Avi: can you review content for me? thanks

[sdefresne, 2014-09-17 17:01:15]

Friendly ping.

[Avi (use Gerrit), 2014-09-18 02:08:32]

lgtm

You talked to the right people, who agreed that this was OK; rubber stamping.

[Ben Goodger (Google), 2014-09-18 03:59:49]

ui/base lgtm

[sdefresne, 2014-09-18 13:10:17]

sdefresne@chromium.org changed reviewers:
+ nasko@chromium.org

[sdefresne, 2014-09-18 13:14:04]

TBR OWNERS for the namespace change.

TBR=nasko for
  content/common/frame_message.h
  content/common/resource_messages.h
  content/public/common/common_param_traits_macros.h

TBR=ben for everything else.

[sdefresne, 2014-09-18 13:14:44]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2014-09-18 13:15:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/562603002/70001

[sdefresne, 2014-09-18 13:15:16]

On 2014/09/18 13:14:04, sdefresne wrote:
> TBR OWNERS for the namespace change.
> 
> TBR=nasko for
>   content/common/frame_message.h
>   content/common/resource_messages.h
>   content/public/common/common_param_traits_macros.h
> 
> TBR=ben for everything else.

I meant, TBR OWNERS of code affected by the namespace change.

[commit-bot: I haz the power, 2014-09-18 13:35:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-18 13:35:14]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sdefresne, 2014-09-18 17:24:45]

sdefresne@chromium.org changed reviewers:
+ wfh@chromium.org
- nasko@chromium.org

[Will Harris, 2014-09-18 17:29:31]

lgtm for the IPC namespace changes

[sdefresne, 2014-09-18 17:33:20]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2014-09-18 17:34:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/562603002/110001

[commit-bot: I haz the power, 2014-09-18 17:48:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-18 17:48:20]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[sdefresne, 2014-09-19 08:43:39]

sdefresne@chromium.org changed reviewers:
+ nasko@chromium.org

[sdefresne, 2014-09-19 08:45:25]

+nasko: I got an LGTM from wfh@ of the security team, but apparently he is not
in the OWNERS list for content/public/common/common_param_traits_macros.h, so
I'm putting you in TBR for that file.

[sdefresne, 2014-09-19 08:56:35]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2014-09-19 08:57:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/562603002/150001

[commit-bot: I haz the power, 2014-09-19 09:19:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-19 09:19:08]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2014-09-19 10:21:16]

Patchset 9 (id:??) landed as
https://crrev.com/c6ccc77dc9c080d83e400dc12205bb805a25ac71
Cr-Commit-Position: refs/heads/master@{#295686}

[sdefresne, 2014-09-19 10:21:20]

Committed patchset #9 (id:150001) manually as c6ccc77 (presubmit successful).

[nasko, 2014-09-22 22:13:20]

On 2014/09/19 10:21:20, sdefresne wrote:
> Committed patchset #9 (id:150001) manually as c6ccc77 (presubmit successful).

Belated rubberstamp LGTM