chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm - Issue 562603002: Move PageTransition from //content/public/common to //ui/base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

Issue 562603002: Move PageTransition from //content/public/common to //ui/base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

diff --git a/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm b/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

index 20e3aca3501a5b2fb6f010726b8c3cc0c843adb5..2cf76db5addf1ae03e79d74034a44b45a7bd53ed 100644

--- a/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

+++ b/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

@@ -2064,7 +2064,7 @@ NSImage* Overlay(NSImage* ground, NSImage* overlay, CGFloat alpha) {

case NEW_FOREGROUND_TAB: {

content::RecordAction(UserMetricsAction("Tab_DropURLBetweenTabs"));

chrome::NavigateParams params(browser_, *url,

- content::PAGE_TRANSITION_TYPED);

+ ui::PAGE_TRANSITION_TYPED);

params.disposition = disposition;

params.tabstrip_index = index;

params.tabstrip_add_types =

@@ -2075,7 +2075,7 @@ NSImage* Overlay(NSImage* ground, NSImage* overlay, CGFloat alpha) {

case CURRENT_TAB: {

content::RecordAction(UserMetricsAction("Tab_DropURLOnTab"));

OpenURLParams params(

- *url, Referrer(), CURRENT_TAB, content::PAGE_TRANSITION_TYPED, false);

+ *url, Referrer(), CURRENT_TAB, ui::PAGE_TRANSITION_TYPED, false);

tabStripModel_->GetWebContentsAt(index)->OpenURL(params);

tabStripModel_->ActivateTabAt(index, true);

break;

« no previous file with comments | « chrome/browser/ui/cocoa/profiles/user_manager_mac.mm ('k') | chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm » ('j') | no next file with comments »