chrome/browser/ui/find_bar/find_bar_host_browsertest.cc - Issue 562603002: Move PageTransition from //content/public/common to //ui/base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/find_bar/find_bar_host_browsertest.cc

Issue 562603002: Move PageTransition from //content/public/common to //ui/base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/find_bar/find_bar_controller.cc ('k') | chrome/browser/ui/fullscreen/fullscreen_controller_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/find_bar/find_bar_host_browsertest.cc

diff --git a/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc b/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc

index 13fc6e0bf207c31463dd29b6bade391141e4b9c1..83e24e8ff26d7a8aa907f2297b05862f49049d58 100644

--- a/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc

+++ b/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc

@@ -1203,7 +1203,7 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, PrepopulateInNewTab) {

EXPECT_EQ(ASCIIToUTF16("1 of 1"), GetMatchCountText());

// Now create a second tab and load the same page.

- chrome::AddSelectedTabWithURL(browser(), url, content::PAGE_TRANSITION_TYPED);

+ chrome::AddSelectedTabWithURL(browser(), url, ui::PAGE_TRANSITION_TYPED);

WebContents* web_contents_2 =

browser()->tab_strip_model()->GetActiveWebContents();

EXPECT_NE(web_contents_1, web_contents_2);

@@ -1328,7 +1328,7 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, MAYBE_NoIncognitoPrepopulate) {

content::NOTIFICATION_LOAD_STOP,

content::NotificationService::AllSources());

chrome::AddSelectedTabWithURL(incognito_browser, url,

- content::PAGE_TRANSITION_AUTO_TOPLEVEL);

+ ui::PAGE_TRANSITION_AUTO_TOPLEVEL);

observer.Wait();

incognito_browser->window()->Show();

@@ -1349,7 +1349,7 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, MAYBE_NoIncognitoPrepopulate) {

FindBarController::kKeepResultsInFindBox);

// Now open a new tab in the original (non-incognito) browser.

- chrome::AddSelectedTabWithURL(browser(), url, content::PAGE_TRANSITION_TYPED);

+ chrome::AddSelectedTabWithURL(browser(), url, ui::PAGE_TRANSITION_TYPED);

WebContents* web_contents_2 =

browser()->tab_strip_model()->GetActiveWebContents();

EXPECT_NE(web_contents_1, web_contents_2);

@@ -1392,7 +1392,7 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, FitWindow) {

content::NOTIFICATION_LOAD_STOP,

content::NotificationService::AllSources());

chrome::AddSelectedTabWithURL(

- popup, GURL(url::kAboutBlankURL), content::PAGE_TRANSITION_LINK);

+ popup, GURL(url::kAboutBlankURL), ui::PAGE_TRANSITION_LINK);

// Wait for the page to finish loading.

observer.Wait();

popup->window()->Show();