content/browser/web_contents/web_contents_impl.cc - Issue 562603002: Move PageTransition from //content/public/common to //ui/base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 562603002: Move PageTransition from //content/public/common to //ui/base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/browser/web_contents/web_contents_impl_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index a9ddf1e4d80ba4819fd062054c7dc4490dbc2a48..14cf8a42cbf21eccfb415e69ffb85cac85fb0cd7 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -1585,7 +1585,7 @@ void WebContentsImpl::CreateNewWindow(

OpenURLParams open_params(params.target_url,

Referrer(),

CURRENT_TAB,

- PAGE_TRANSITION_LINK,

+ ui::PAGE_TRANSITION_LINK,

true /* is_renderer_initiated */);

open_params.user_gesture = params.user_gesture;

new_contents->OpenURL(open_params);

@@ -2574,7 +2574,7 @@ void WebContentsImpl::DidRedirectProvisionalLoad(

void WebContentsImpl::DidCommitProvisionalLoad(

RenderFrameHostImpl* render_frame_host,

const GURL& url,

- PageTransition transition_type) {

+ ui::PageTransition transition_type) {

// Notify observers about the commit of the provisional load.

FOR_EACH_OBSERVER(WebContentsObserver,

observers_,

« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/browser/web_contents/web_contents_impl_browsertest.cc » ('j') | no next file with comments »