Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: chrome/browser/safe_browsing/browser_feature_extractor.cc

Issue 562603002: Move PageTransition from //content/public/common to //ui/base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/browser_feature_extractor.cc
diff --git a/chrome/browser/safe_browsing/browser_feature_extractor.cc b/chrome/browser/safe_browsing/browser_feature_extractor.cc
index 0a37c7fb520f1df8be29c7f20336016e12720d17..4bb6e5d038939ee5e5e0c7c119500fcb3684faee 100644
--- a/chrome/browser/safe_browsing/browser_feature_extractor.cc
+++ b/chrome/browser/safe_browsing/browser_feature_extractor.cc
@@ -25,7 +25,7 @@
#include "content/public/browser/navigation_controller.h"
#include "content/public/browser/navigation_entry.h"
#include "content/public/browser/web_contents.h"
-#include "content/public/common/page_transition_types.h"
+#include "ui/base/page_transition_types.h"
#include "url/gurl.h"
using content::BrowserThread;
@@ -122,7 +122,7 @@ static void AddNavigationFeatures(
request);
AddFeature(feature_prefix + features::kPageTransitionType,
static_cast<double>(
- content::PageTransitionStripQualifier(
+ ui::PageTransitionStripQualifier(
entry->GetTransitionType())),
request);
AddFeature(feature_prefix + features::kIsFirstNavigation,
@@ -345,17 +345,17 @@ void BrowserFeatureExtractor::QueryUrlHistoryDone(
for (history::VisitVector::const_iterator it = visits.begin();
it != visits.end();
++it) {
- if (!content::PageTransitionIsMainFrame(it->transition)) {
+ if (!ui::PageTransitionIsMainFrame(it->transition)) {
continue;
}
if (it->visit_time < threshold) {
++num_visits_24h_ago;
}
- content::PageTransition transition = content::PageTransitionStripQualifier(
+ ui::PageTransition transition = ui::PageTransitionStripQualifier(
it->transition);
- if (transition == content::PAGE_TRANSITION_TYPED) {
+ if (transition == ui::PAGE_TRANSITION_TYPED) {
++num_visits_typed;
- } else if (transition == content::PAGE_TRANSITION_LINK) {
+ } else if (transition == ui::PAGE_TRANSITION_LINK) {
++num_visits_link;
}
}
« no previous file with comments | « chrome/browser/rlz/rlz_unittest.cc ('k') | chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698