chrome/browser/ui/find_bar/find_bar_controller.cc - Issue 562603002: Move PageTransition from //content/public/common to //ui/base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/find_bar/find_bar_controller.cc

Issue 562603002: Move PageTransition from //content/public/common to //ui/base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/extensions/extension_install_ui_default.cc ('k') | chrome/browser/ui/find_bar/find_bar_host_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/find_bar/find_bar_controller.cc

diff --git a/chrome/browser/ui/find_bar/find_bar_controller.cc b/chrome/browser/ui/find_bar/find_bar_controller.cc

index 5241fa4a190f10643968ddf671a14a8c696535b5..b0bdf9b83e658f66d3d38977a62b287789d45dc8 100644

--- a/chrome/browser/ui/find_bar/find_bar_controller.cc

+++ b/chrome/browser/ui/find_bar/find_bar_controller.cc

@@ -153,12 +153,12 @@ void FindBarController::Observe(int type,

if (source_controller == &web_contents_->GetController()) {

content::LoadCommittedDetails* commit_details =

content::Details<content::LoadCommittedDetails>(details).ptr();

- content::PageTransition transition_type =

+ ui::PageTransition transition_type =

commit_details->entry->GetTransitionType();

// Hide the find bar on reload or navigation.

if (find_bar_->IsFindBarVisible() &&

- (content::PageTransitionStripQualifier(transition_type) ==

- content::PAGE_TRANSITION_RELOAD ||

+ (ui::PageTransitionStripQualifier(transition_type) ==

+ ui::PAGE_TRANSITION_RELOAD ||

commit_details->is_navigation_to_different_page()))

EndFindSession(kKeepSelectionOnPage, kClearResultsInFindBox);

}