Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Side by Side Diff: chrome/browser/platform_util_chromeos.cc

Issue 562603002: Move PageTransition from //content/public/common to //ui/base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/platform_util.h" 5 #include "chrome/browser/platform_util.h"
6 6
7 #include "chrome/browser/chromeos/file_manager/open_util.h" 7 #include "chrome/browser/chromeos/file_manager/open_util.h"
8 #include "chrome/browser/ui/browser_navigator.h" 8 #include "chrome/browser/ui/browser_navigator.h"
9 #include "content/public/browser/browser_thread.h" 9 #include "content/public/browser/browser_thread.h"
10 #include "url/gurl.h" 10 #include "url/gurl.h"
(...skipping 24 matching lines...) Expand all
35 35
36 // This code should be obsolete since we have default handlers in ChromeOS 36 // This code should be obsolete since we have default handlers in ChromeOS
37 // which should handle this. However - there are two things which make it 37 // which should handle this. However - there are two things which make it
38 // necessary to keep it in: 38 // necessary to keep it in:
39 // a.) The user might have deleted the default handler in this session. 39 // a.) The user might have deleted the default handler in this session.
40 // In this case we would need to have this in place. 40 // In this case we would need to have this in place.
41 // b.) There are several code paths which are not clear if they would call 41 // b.) There are several code paths which are not clear if they would call
42 // this function directly and which would therefore break (e.g. 42 // this function directly and which would therefore break (e.g.
43 // "Browser::EmailPageLocation" (to name only one). 43 // "Browser::EmailPageLocation" (to name only one).
44 // As such we should keep this code here. 44 // As such we should keep this code here.
45 chrome::NavigateParams params(profile, url, content::PAGE_TRANSITION_LINK); 45 chrome::NavigateParams params(profile, url, ui::PAGE_TRANSITION_LINK);
46 params.disposition = NEW_FOREGROUND_TAB; 46 params.disposition = NEW_FOREGROUND_TAB;
47 params.host_desktop_type = chrome::HOST_DESKTOP_TYPE_ASH; 47 params.host_desktop_type = chrome::HOST_DESKTOP_TYPE_ASH;
48 48
49 if (url.SchemeIs("mailto")) { 49 if (url.SchemeIs("mailto")) {
50 std::string string_url = kGmailComposeUrl; 50 std::string string_url = kGmailComposeUrl;
51 string_url.append(url.spec()); 51 string_url.append(url.spec());
52 params.url = GURL(url); 52 params.url = GURL(url);
53 } 53 }
54 54
55 chrome::Navigate(&params); 55 chrome::Navigate(&params);
56 } 56 }
57 57
58 } // namespace platform_util 58 } // namespace platform_util
OLDNEW
« no previous file with comments | « chrome/browser/pepper_broker_infobar_delegate.cc ('k') | chrome/browser/plugins/plugin_infobar_delegates.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698