chrome/browser/ui/autofill/generated_credit_card_bubble_controller.cc - Issue 562603002: Move PageTransition from //content/public/common to //ui/base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/generated_credit_card_bubble_controller.cc

Issue 562603002: Move PageTransition from //content/public/common to //ui/base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc ('k') | chrome/browser/ui/autofill/generated_credit_card_bubble_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/generated_credit_card_bubble_controller.cc

diff --git a/chrome/browser/ui/autofill/generated_credit_card_bubble_controller.cc b/chrome/browser/ui/autofill/generated_credit_card_bubble_controller.cc

index 5eef3e935ef7978e30784828c3c685c37bdbf54d..dcfdba88cf233a7df6ddd55010f396e8dd992b2d 100644

--- a/chrome/browser/ui/autofill/generated_credit_card_bubble_controller.cc

+++ b/chrome/browser/ui/autofill/generated_credit_card_bubble_controller.cc

@@ -92,10 +92,10 @@ void GeneratedCreditCardBubbleController::DidNavigateMainFrame(

// Don't destory the bubble due to reloads, form submits, or redirects right

// after the dialog succeeds. Merchants often navigate to a confirmation page.

- content::PageTransition transition = details.entry->GetTransitionType();

- if (transition == content::PAGE_TRANSITION_FORM_SUBMIT ||

- transition == content::PAGE_TRANSITION_RELOAD ||

- content::PageTransitionIsRedirect(transition)) {

+ ui::PageTransition transition = details.entry->GetTransitionType();

+ if (transition == ui::PAGE_TRANSITION_FORM_SUBMIT ||

+ transition == ui::PAGE_TRANSITION_RELOAD ||

+ ui::PageTransitionIsRedirect(transition)) {

return;

}

@@ -138,7 +138,7 @@ void GeneratedCreditCardBubbleController::OnLinkClicked() {

chrome::NavigateParams params(

chrome::FindBrowserWithWebContents(web_contents()),

GURL(kWalletGeneratedCardLearnMoreLink),

- content::PAGE_TRANSITION_AUTO_BOOKMARK);

+ ui::PAGE_TRANSITION_AUTO_BOOKMARK);

params.disposition = NEW_FOREGROUND_TAB;

chrome::Navigate(&params);