content/browser/webui/generic_handler.cc - Issue 562603002: Move PageTransition from //content/public/common to //ui/base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/webui/generic_handler.cc

Issue 562603002: Move PageTransition from //content/public/common to //ui/base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/webui/generic_handler.cc

diff --git a/content/browser/webui/generic_handler.cc b/content/browser/webui/generic_handler.cc

index 058382fa8a8337c73fa21f68df9b8ef95eadda6d..b26bcd9294a3232e2c4738a4f94596d9c0d9d52e 100644

--- a/content/browser/webui/generic_handler.cc

+++ b/content/browser/webui/generic_handler.cc

@@ -50,8 +50,11 @@ void GenericHandler::HandleNavigateToUrl(const base::ListValue* args) {

if (disposition == CURRENT_TAB && target_string == "_blank")

disposition = NEW_FOREGROUND_TAB;

- web_ui()->GetWebContents()->OpenURL(OpenURLParams(

- GURL(url_string), Referrer(), disposition, PAGE_TRANSITION_LINK, false));

+ web_ui()->GetWebContents()->OpenURL(OpenURLParams(GURL(url_string),

+ Referrer(),

+ disposition,

+ ui::PAGE_TRANSITION_LINK,

+ false));

// This may delete us!

}

« no previous file with comments | « content/browser/web_contents/web_drag_dest_mac.mm ('k') | content/browser/webui/web_ui_impl.h » ('j') | no next file with comments »