chrome/browser/extensions/extension_tab_util.cc - Issue 562603002: Move PageTransition from //content/public/common to //ui/base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_tab_util.cc

Issue 562603002: Move PageTransition from //content/public/common to //ui/base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_message_bubble_controller.cc ('k') | chrome/browser/extensions/extension_web_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_tab_util.cc

diff --git a/chrome/browser/extensions/extension_tab_util.cc b/chrome/browser/extensions/extension_tab_util.cc

index 46ca9f3570fb94845f08596cfb53d29313c39cfa..3d38e4f55d8eca61a090b757af7b2a6e2989514d 100644

--- a/chrome/browser/extensions/extension_tab_util.cc

+++ b/chrome/browser/extensions/extension_tab_util.cc

@@ -233,7 +233,7 @@ base::DictionaryValue* ExtensionTabUtil::OpenTab(

if (pinned)

add_types |= TabStripModel::ADD_PINNED;

chrome::NavigateParams navigate_params(

- browser, url, content::PAGE_TRANSITION_LINK);

+ browser, url, ui::PAGE_TRANSITION_LINK);

navigate_params.disposition =

active ? NEW_FOREGROUND_TAB : NEW_BACKGROUND_TAB;

navigate_params.tabstrip_index = index;

@@ -610,7 +610,7 @@ void ExtensionTabUtil::OpenOptionsPage(const Extension* extension,

content::OpenURLParams params(OptionsPageInfo::GetOptionsPage(extension),

content::Referrer(),

SINGLETON_TAB,

- content::PAGE_TRANSITION_LINK,

+ ui::PAGE_TRANSITION_LINK,

false);

browser->OpenURL(params);

browser->window()->Show();

« no previous file with comments | « chrome/browser/extensions/extension_message_bubble_controller.cc ('k') | chrome/browser/extensions/extension_web_ui.cc » ('j') | no next file with comments »