chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc - Issue 562603002: Move PageTransition from //content/public/common to //ui/base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

Issue 562603002: Move PageTransition from //content/public/common to //ui/base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc ('k') | chrome/browser/extensions/api/webstore_private/webstore_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc b/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

index efc9a1205f0b25c2f97ab7e3d703e4034e6eeff5..ef6316561a034ca5cb7dc8ab911738d20edc00ef 100644

--- a/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

@@ -192,7 +192,7 @@ class DelayLoadStartAndExecuteJavascript

virtual void DidCommitProvisionalLoadForFrame(

content::RenderFrameHost* render_frame_host,

const GURL& url,

- content::PageTransition transition_type) OVERRIDE {

+ ui::PageTransition transition_type) OVERRIDE {

if (script_was_executed_ && EndsWith(url.spec(), until_url_suffix_, true)) {

content::WebContentsObserver::Observe(NULL);

test_navigation_listener_->ResumeAll();

@@ -484,7 +484,7 @@ IN_PROC_BROWSER_TEST_F(WebNavigationApiTest, TargetBlank) {

GURL url = embedded_test_server()->GetURL(

"/extensions/api_test/webnavigation/targetBlank/a.html");

- chrome::NavigateParams params(browser(), url, content::PAGE_TRANSITION_LINK);

+ chrome::NavigateParams params(browser(), url, ui::PAGE_TRANSITION_LINK);

ui_test_utils::NavigateToURL(&params);

// There's a link with target=_blank on a.html. Click on it to open it in a