chrome/browser/history/android/visit_sql_handler.cc - Issue 562603002: Move PageTransition from //content/public/common to //ui/base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/android/visit_sql_handler.cc

Issue 562603002: Move PageTransition from //content/public/common to //ui/base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/history/android/android_provider_backend_unittest.cc ('k') | chrome/browser/history/expire_history_backend.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/history/android/visit_sql_handler.cc

diff --git a/chrome/browser/history/android/visit_sql_handler.cc b/chrome/browser/history/android/visit_sql_handler.cc

index fe9c1e50014d892bc10ea40a2bebd5f58eaa51cf..29be69fa8ff0218f3995de55111431a1a0692f98 100644

--- a/chrome/browser/history/android/visit_sql_handler.cc

+++ b/chrome/browser/history/android/visit_sql_handler.cc

@@ -113,10 +113,10 @@ bool VisitSQLHandler::Delete(const TableIDRows& ids_set) {

}

bool VisitSQLHandler::AddVisit(URLID url_id, const Time& visit_time) {

- // TODO : Is 'content::PAGE_TRANSITION_AUTO_BOOKMARK' proper?

- // if not, a new content::PageTransition type will need.

+ // TODO : Is 'ui::PAGE_TRANSITION_AUTO_BOOKMARK' proper?

+ // if not, a new ui::PageTransition type will need.

VisitRow visit_row(url_id, visit_time, 0,

- content::PAGE_TRANSITION_AUTO_BOOKMARK, 0);

+ ui::PAGE_TRANSITION_AUTO_BOOKMARK, 0);

return history_db_->AddVisit(&visit_row, SOURCE_BROWSED);

}