chrome/browser/ui/webui/ntp/suggestions_page_handler.cc - Issue 562603002: Move PageTransition from //content/public/common to //ui/base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/suggestions_page_handler.cc

Issue 562603002: Move PageTransition from //content/public/common to //ui/base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc ('k') | chrome/browser/ui/webui/options/advanced_options_utils_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/ntp/suggestions_page_handler.cc

diff --git a/chrome/browser/ui/webui/ntp/suggestions_page_handler.cc b/chrome/browser/ui/webui/ntp/suggestions_page_handler.cc

index ba02ac8202f1dff38991b18309ad77ae3cdc165f..4d606fe2d0c02ebc3797f0e909e93accedd24cf1 100644

--- a/chrome/browser/ui/webui/ntp/suggestions_page_handler.cc

+++ b/chrome/browser/ui/webui/ntp/suggestions_page_handler.cc

@@ -33,7 +33,7 @@

#include "content/public/browser/user_metrics.h"

#include "content/public/browser/web_contents.h"

#include "content/public/browser/web_ui.h"

-#include "content/public/common/page_transition_types.h"

+#include "ui/base/page_transition_types.h"

#include "url/gurl.h"

using base::UserMetricsAction;

@@ -52,7 +52,7 @@ SuggestionsHandler::~SuggestionsHandler() {

web_ui()->GetWebContents()->GetController().GetLastCommittedEntry();

if (entry && (entry->GetURL() != ntp_url)) {

action_id =

- content::PageTransitionStripQualifier(entry->GetTransitionType());

+ ui::PageTransitionStripQualifier(entry->GetTransitionType());

}

UMA_HISTOGRAM_ENUMERATION("NewTabPage.SuggestedSitesAction", action_id,