Refactoring the WeakPtrFactory usage, Member variables should appear before the WeakPtrFactory, to …

Refactoring the WeakPtrFactory usage, Member variables should appear before the WeakPtrFactory, to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructors are executed, rendering them invalid.

BUG=303818
Committed: https://crrev.com/d97aafa2698638f2f207538980014b6e461e382c
Cr-Commit-Position: refs/heads/master@{#294163}

[MRV, 2014-09-09 09:39:42]

mohan.reddy@samsung.com changed reviewers:
+ ben@chromium.org, blundell@chromium.org, darin@chromium.org

[MRV, 2014-09-09 09:39:42]

ben@chromium.org: Please review changes in src/components

darin@chromium.org: Please review changes in src/components

blundell@chromium.org: Please review changes in src/components

PTAL

[blundell, 2014-09-09 14:50:52]

You don't need Ben or Darin's review here.

https://codereview.chromium.org/554233002/diff/1/components/storage_monitor/p...
File components/storage_monitor/portable_device_watcher_win.h (right):

https://codereview.chromium.org/554233002/diff/1/components/storage_monitor/p...
components/storage_monitor/portable_device_watcher_win.h:137: 
No change in initialization order is needed?

[MRV, 2014-09-10 03:01:20]

Thanks Mr. Blundell for your review.
updated my inline comments.
PTAL

https://codereview.chromium.org/554233002/diff/1/components/storage_monitor/p...
File components/storage_monitor/portable_device_watcher_win.h (right):

https://codereview.chromium.org/554233002/diff/1/components/storage_monitor/p...
components/storage_monitor/portable_device_watcher_win.h:137: 
On 2014/09/09 14:50:52, blundell wrote:
> No change in initialization order is needed?

I agree with you Mr.Blundell, I thought the order of initialization in
contructor is already maintained in proper order in .cc file, I felt it will be
better, if we manage the same in the .h file also, so incorporated these
changes.

PortableDeviceWatcherWin::PortableDeviceWatcherWin()
    : notifications_(NULL),
      storage_notifications_(NULL),
      weak_ptr_factory_(this) {
}

Let me know your views on the same, I'll revert the file based on  your opinion.

[blundell, 2014-09-10 06:25:04]

LGTM

https://codereview.chromium.org/554233002/diff/1/components/storage_monitor/p...
File components/storage_monitor/portable_device_watcher_win.h (right):

https://codereview.chromium.org/554233002/diff/1/components/storage_monitor/p...
components/storage_monitor/portable_device_watcher_win.h:137: 
On 2014/09/10 03:01:20, MRV wrote:
> On 2014/09/09 14:50:52, blundell wrote:
> > No change in initialization order is needed?
> 
> I agree with you Mr.Blundell, I thought the order of initialization in
> contructor is already maintained in proper order in .cc file, I felt it will
be
> better, if we manage the same in the .h file also, so incorporated these
> changes.
> 
> PortableDeviceWatcherWin::PortableDeviceWatcherWin()
>     : notifications_(NULL),
>       storage_notifications_(NULL),
>       weak_ptr_factory_(this) {
> }
> 
> Let me know your views on the same, I'll revert the file based on  your
opinion.

You've done the right thing, thanks.

[MRV, 2014-09-10 06:26:33]

Thanks Mr. blundell for LGTM

[MRV, 2014-09-10 06:26:37]

The CQ bit was checked by mohan.reddy@samsung.com

[commit-bot: I haz the power, 2014-09-10 06:28:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mohan.reddy@samsung.com/554233002/1

[commit-bot: I haz the power, 2014-09-10 07:52:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-10 07:52:07]

Try jobs failed on following builders:
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[MRV, 2014-09-10 12:57:25]

The CQ bit was checked by mohan.reddy@samsung.com

[commit-bot: I haz the power, 2014-09-10 12:58:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mohan.reddy@samsung.com/554233002/1

[commit-bot: I haz the power, 2014-09-10 13:38:58]

Committed patchset #1 (id:1) as e836da3b6bd712032a5f1c612493fdd7ddfb09a3

[commit-bot: I haz the power, 2014-09-10 13:44:50]

Patchset 1 (id:??) landed as
https://crrev.com/d97aafa2698638f2f207538980014b6e461e382c
Cr-Commit-Position: refs/heads/master@{#294163}