Refactoring the WeakPtrFactory usage, Member variables should appear before the WeakPtrFactory, to …

components/storage_monitor/portable_device_watcher_win.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_STORAGE_MONITOR_PORTABLE_DEVICE_WATCHER_WIN_H_
 #define COMPONENTS_STORAGE_MONITOR_PORTABLE_DEVICE_WATCHER_WIN_H_
 
 #include <portabledeviceapi.h>
 
 #include <map>
@@ skipping 114 matching lines @@
   // Attached media transfer protocol device map.
   MTPDeviceMap device_map_;
 
   // Attached media transfer protocol device storage objects map.
   MTPStorageMap storage_map_;
 
   // The task runner used to execute tasks that may take a long time and thus
   // should not be performed on the UI thread.
   scoped_refptr<base::SequencedTaskRunner> media_task_runner_;
 
+  // The notifications object to use to signal newly attached devices.
+  StorageMonitor::Receiver* storage_notifications_;
+

[blundell, 2014/09/09 14:50:52]

No change in initialization order is needed?

[MRV, 2014/09/10 03:01:20]

I agree with you Mr.Blundell, I thought the order of initialization in
contructor is already maintained in proper order in .cc file, I felt it will be
better, if we manage the same in the .h file also, so incorporated these
changes.

PortableDeviceWatcherWin::PortableDeviceWatcherWin()
    : notifications_(NULL),
      storage_notifications_(NULL),
      weak_ptr_factory_(this) {
}

Let me know your views on the same, I'll revert the file based on  your opinion.

[blundell, 2014/09/10 06:25:04]

You've done the right thing, thanks.

   // Used by |media_task_runner_| to create cancelable callbacks.
   base::WeakPtrFactory<PortableDeviceWatcherWin> weak_ptr_factory_;
 
-  // The notifications object to use to signal newly attached devices.
-  StorageMonitor::Receiver* storage_notifications_;
-
   DISALLOW_COPY_AND_ASSIGN(PortableDeviceWatcherWin);
 };
 
 }  // namespace storage_monitor
 
 #endif  // COMPONENTS_STORAGE_MONITOR_PORTABLE_DEVICE_WATCHER_WIN_H_