components/nacl/browser/nacl_process_host.cc - Issue 554233002: Refactoring the WeakPtrFactory usage, Member variables should appear before the WeakPtrFactory, to …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/browser/nacl_process_host.cc

Issue 554233002: Refactoring the WeakPtrFactory usage, Member variables should appear before the WeakPtrFactory, to … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/nacl/browser/nacl_process_host.h ('k') | components/policy/core/common/async_policy_loader.h » ('j') | components/storage_monitor/portable_device_watcher_win.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/nacl/browser/nacl_process_host.cc

diff --git a/components/nacl/browser/nacl_process_host.cc b/components/nacl/browser/nacl_process_host.cc

index 33b071f07b1ebfa91b9f301160080bf66f23293f..defc29fd6724dae30418af0e92183f07c8c08f96 100644

--- a/components/nacl/browser/nacl_process_host.cc

+++ b/components/nacl/browser/nacl_process_host.cc

@@ -274,7 +274,6 @@ NaClProcessHost::NaClProcessHost(const GURL& manifest_url,

debug_exception_handler_requested_(false),

#endif

internal_(new NaClInternal()),

- weak_factory_(this),

uses_irt_(uses_irt),

uses_nonsfi_mode_(uses_nonsfi_mode),

enable_debug_stub_(false),

@@ -283,7 +282,8 @@ NaClProcessHost::NaClProcessHost(const GURL& manifest_url,

enable_crash_throttling_(enable_crash_throttling),

off_the_record_(off_the_record),

profile_directory_(profile_directory),

- render_view_id_(render_view_id) {

+ render_view_id_(render_view_id),

+ weak_factory_(this) {

process_.reset(content::BrowserChildProcessHost::Create(

PROCESS_TYPE_NACL_LOADER, this));