Refactoring the WeakPtrFactory usage, Member variables should appear before the WeakPtrFactory, to …

components/storage_monitor/portable_device_watcher_win.h

Index: components/storage_monitor/portable_device_watcher_win.h
diff --git a/components/storage_monitor/portable_device_watcher_win.h b/components/storage_monitor/portable_device_watcher_win.h
index cc5e54aac144c95d74e8ff928992b1217b62d02b..a0b47c44497b430ed606972e08480628091e26ec 100644
--- a/components/storage_monitor/portable_device_watcher_win.h
+++ b/components/storage_monitor/portable_device_watcher_win.h
@@ -132,12 +132,12 @@ class PortableDeviceWatcherWin {
   // should not be performed on the UI thread.
   scoped_refptr<base::SequencedTaskRunner> media_task_runner_;
 
-  // Used by |media_task_runner_| to create cancelable callbacks.
-  base::WeakPtrFactory<PortableDeviceWatcherWin> weak_ptr_factory_;
-
   // The notifications object to use to signal newly attached devices.
   StorageMonitor::Receiver* storage_notifications_;
 

[blundell, 2014/09/09 14:50:52]

No change in initialization order is needed?

[MRV, 2014/09/10 03:01:20]

I agree with you Mr.Blundell, I thought the order of initialization in
contructor is already maintained in proper order in .cc file, I felt it will be
better, if we manage the same in the .h file also, so incorporated these
changes.

PortableDeviceWatcherWin::PortableDeviceWatcherWin()
    : notifications_(NULL),
      storage_notifications_(NULL),
      weak_ptr_factory_(this) {
}

Let me know your views on the same, I'll revert the file based on  your opinion.

[blundell, 2014/09/10 06:25:04]

You've done the right thing, thanks.

+  // Used by |media_task_runner_| to create cancelable callbacks.
+  base::WeakPtrFactory<PortableDeviceWatcherWin> weak_ptr_factory_;
+
   DISALLOW_COPY_AND_ASSIGN(PortableDeviceWatcherWin);
 };