Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/suggestions/suggestions_service.cc

Issue 554233002: Refactoring the WeakPtrFactory usage, Member variables should appear before the WeakPtrFactory, to … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/storage_monitor/portable_device_watcher_win.h ('K') | « components/suggestions/suggestions_service.h ('k') | components/sync_driver/model_association_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/suggestions/suggestions_service.cc
diff --git a/components/suggestions/suggestions_service.cc b/components/suggestions/suggestions_service.cc
index b12aae1a1cc4010f46d833ceba1282c6afc72962..e7b03979a8ae4173d8df1b95f689400306b890b8 100644
--- a/components/suggestions/suggestions_service.cc
+++ b/components/suggestions/suggestions_service.cc
@@ -127,8 +127,8 @@ SuggestionsService::SuggestionsService(
thumbnail_manager_(thumbnail_manager.Pass()),
url_request_context_(url_request_context),
blacklist_delay_sec_(kBlacklistDefaultDelaySec),
- weak_ptr_factory_(this),
- request_timeout_ms_(kDefaultRequestTimeoutMs) {
+ request_timeout_ms_(kDefaultRequestTimeoutMs),
+ weak_ptr_factory_(this) {
// Obtain various parameters from Variations.
suggestions_url_ =
GURL(GetExperimentParam(kSuggestionsFieldTrialURLParam) + "?" +
« components/storage_monitor/portable_device_watcher_win.h ('K') | « components/suggestions/suggestions_service.h ('k') | components/sync_driver/model_association_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698