components/nacl/browser/nacl_process_host.h - Issue 554233002: Refactoring the WeakPtrFactory usage, Member variables should appear before the WeakPtrFactory, to …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/browser/nacl_process_host.h

Issue 554233002: Refactoring the WeakPtrFactory usage, Member variables should appear before the WeakPtrFactory, to … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/nacl/browser/nacl_browser.cc ('k') | components/nacl/browser/nacl_process_host.cc » ('j') | components/storage_monitor/portable_device_watcher_win.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/nacl/browser/nacl_process_host.h

diff --git a/components/nacl/browser/nacl_process_host.h b/components/nacl/browser/nacl_process_host.h

index 31e0d602ec0ced19627286fff805ea72a95d53eb..3b358b52f89b7651c1d77bef6583d94df381cab5 100644

--- a/components/nacl/browser/nacl_process_host.h

+++ b/components/nacl/browser/nacl_process_host.h

@@ -223,8 +223,6 @@ class NaClProcessHost : public content::BrowserChildProcessHostDelegate {

// Socket pairs for the NaCl process and renderer.

scoped_ptr<NaClInternal> internal_;

- base::WeakPtrFactory<NaClProcessHost> weak_factory_;

scoped_ptr<content::BrowserChildProcessHost> process_;

bool uses_irt_;

@@ -253,6 +251,8 @@ class NaClProcessHost : public content::BrowserChildProcessHostDelegate {

// reporting crash information.

base::SharedMemory crash_info_shmem_;

+ base::WeakPtrFactory<NaClProcessHost> weak_factory_;

DISALLOW_COPY_AND_ASSIGN(NaClProcessHost);

};