components/autofill/core/browser/webdata/autofill_webdata_service.cc - Issue 554233002: Refactoring the WeakPtrFactory usage, Member variables should appear before the WeakPtrFactory, to …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/webdata/autofill_webdata_service.cc

Issue 554233002: Refactoring the WeakPtrFactory usage, Member variables should appear before the WeakPtrFactory, to … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/webdata/autofill_webdata_service.h ('k') | components/nacl/browser/nacl_browser.h » ('j') | components/storage_monitor/portable_device_watcher_win.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/webdata/autofill_webdata_service.cc

diff --git a/components/autofill/core/browser/webdata/autofill_webdata_service.cc b/components/autofill/core/browser/webdata/autofill_webdata_service.cc

index 08f4c0334122cf02b4e0822ba8e72ff59319381a..c8c65b77cfe34366903f0211f18c18a150dbbf41 100644

--- a/components/autofill/core/browser/webdata/autofill_webdata_service.cc

+++ b/components/autofill/core/browser/webdata/autofill_webdata_service.cc

@@ -33,8 +33,8 @@ AutofillWebDataService::AutofillWebDataService(

: WebDataServiceBase(wdbs, callback, ui_thread),

ui_thread_(ui_thread),

db_thread_(db_thread),

- weak_ptr_factory_(this),

- autofill_backend_(NULL) {

+ autofill_backend_(NULL),

+ weak_ptr_factory_(this) {

base::Closure on_changed_callback = Bind(

&AutofillWebDataService::NotifyAutofillMultipleChangedOnUIThread,

@@ -51,11 +51,11 @@ AutofillWebDataService::AutofillWebDataService(

ui_thread),

ui_thread_(ui_thread),

db_thread_(db_thread),

- weak_ptr_factory_(this),

autofill_backend_(new AutofillWebDataBackendImpl(NULL,

ui_thread_,

db_thread_,

- base::Closure())) {

+ base::Closure())),

+ weak_ptr_factory_(this) {

}

void AutofillWebDataService::ShutdownOnUIThread() {