components/nacl/browser/nacl_browser.cc - Issue 554233002: Refactoring the WeakPtrFactory usage, Member variables should appear before the WeakPtrFactory, to …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/browser/nacl_browser.cc

Issue 554233002: Refactoring the WeakPtrFactory usage, Member variables should appear before the WeakPtrFactory, to … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/nacl/browser/nacl_browser.h ('k') | components/nacl/browser/nacl_process_host.h » ('j') | components/storage_monitor/portable_device_watcher_win.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/nacl/browser/nacl_browser.cc

diff --git a/components/nacl/browser/nacl_browser.cc b/components/nacl/browser/nacl_browser.cc

index 2982fdc1719b08fdaa882138fd43014c94ebeca7..c76862ae290f5b2af74c02b75713d51879d3a45f 100644

--- a/components/nacl/browser/nacl_browser.cc

+++ b/components/nacl/browser/nacl_browser.cc

@@ -137,8 +137,7 @@ base::File OpenNaClReadExecImpl(const base::FilePath& file_path,

}

NaClBrowser::NaClBrowser()

- : weak_factory_(this),

- irt_filepath_(),

+ : irt_filepath_(),

irt_state_(NaClResourceUninitialized),

validation_cache_file_path_(),

validation_cache_is_enabled_(

@@ -147,7 +146,8 @@ NaClBrowser::NaClBrowser()

validation_cache_is_modified_(false),

validation_cache_state_(NaClResourceUninitialized),

path_cache_(kFilePathCacheSize),

- ok_(true) {

+ ok_(true),

+ weak_factory_(this) {

}

void NaClBrowser::SetDelegate(NaClBrowserDelegate* delegate) {