Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Unified Diff: components/signin/core/browser/signin_manager.h

Issue 554233002: Refactoring the WeakPtrFactory usage, Member variables should appear before the WeakPtrFactory, to … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/signin_manager.h
diff --git a/components/signin/core/browser/signin_manager.h b/components/signin/core/browser/signin_manager.h
index 275621a34432efdd88db14d79c77005e9e0fe7d6..5868e0d907b23198981aa780045d2d0e5c074f7a 100644
--- a/components/signin/core/browser/signin_manager.h
+++ b/components/signin/core/browser/signin_manager.h
@@ -193,8 +193,6 @@ class SigninManager : public SigninManagerBase {
// token service so that it does not need to mint new ones.
std::string temp_refresh_token_;
- base::WeakPtrFactory<SigninManager> weak_pointer_factory_;
-
// The SigninClient object associated with this object. Must outlive this
// object.
SigninClient* client_;
@@ -213,6 +211,8 @@ class SigninManager : public SigninManagerBase {
// Helper to merge signed in account into the content area.
scoped_ptr<MergeSessionHelper> merge_session_helper_;
+ base::WeakPtrFactory<SigninManager> weak_pointer_factory_;
+
DISALLOW_COPY_AND_ASSIGN(SigninManager);
};

Powered by Google App Engine
This is Rietveld 408576698