Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: components/nacl/browser/nacl_browser.h

Issue 554233002: Refactoring the WeakPtrFactory usage, Member variables should appear before the WeakPtrFactory, to … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/browser/nacl_browser.h
diff --git a/components/nacl/browser/nacl_browser.h b/components/nacl/browser/nacl_browser.h
index 8e3e9eff3f4dac2bfd5bdca2997700f6df82a9c8..21e3ac7504e70c63046beccff483145837f6334e 100644
--- a/components/nacl/browser/nacl_browser.h
+++ b/components/nacl/browser/nacl_browser.h
@@ -170,8 +170,6 @@ class NaClBrowser {
void MarkValidationCacheAsModified();
void PersistValidationCache();
- // Singletons get destroyed at shutdown.
- base::WeakPtrFactory<NaClBrowser> weak_factory_;
base::File irt_file_;
base::FilePath irt_filepath_;
@@ -200,6 +198,9 @@ class NaClBrowser {
std::deque<base::Time> crash_times_;
+ // Singletons get destroyed at shutdown.
+ base::WeakPtrFactory<NaClBrowser> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(NaClBrowser);
};

Powered by Google App Engine
This is Rietveld 408576698