Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Unified Diff: components/policy/core/common/async_policy_loader.h

Issue 554233002: Refactoring the WeakPtrFactory usage, Member variables should appear before the WeakPtrFactory, to … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/async_policy_loader.h
diff --git a/components/policy/core/common/async_policy_loader.h b/components/policy/core/common/async_policy_loader.h
index 652102762d9ff3e9945631d2e4d4edb5ff30e86b..d10608ec7f55f9786dd642f7781f5f97b8e11601 100644
--- a/components/policy/core/common/async_policy_loader.h
+++ b/components/policy/core/common/async_policy_loader.h
@@ -99,9 +99,6 @@ class POLICY_EXPORT AsyncPolicyLoader {
// Callback for updates, passed in Init().
UpdateCallback update_callback_;
- // Used to get WeakPtrs for the periodic reload task.
- base::WeakPtrFactory<AsyncPolicyLoader> weak_factory_;
-
// Records last known modification timestamp.
base::Time last_modification_time_;
@@ -114,6 +111,9 @@ class POLICY_EXPORT AsyncPolicyLoader {
// The current policy schemas that this provider should load.
scoped_refptr<SchemaMap> schema_map_;
+ // Used to get WeakPtrs for the periodic reload task.
+ base::WeakPtrFactory<AsyncPolicyLoader> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(AsyncPolicyLoader);
};

Powered by Google App Engine
This is Rietveld 408576698