Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: components/autofill/core/browser/webdata/autofill_webdata_service.h

Issue 554233002: Refactoring the WeakPtrFactory usage, Member variables should appear before the WeakPtrFactory, to … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/webdata/autofill_webdata_service.h
diff --git a/components/autofill/core/browser/webdata/autofill_webdata_service.h b/components/autofill/core/browser/webdata/autofill_webdata_service.h
index d2353cae6bb7a4f7acb9c1c9226bdb826e30da4c..0a2d97d531e94b657da211b97cb6e8cac620c99c 100644
--- a/components/autofill/core/browser/webdata/autofill_webdata_service.h
+++ b/components/autofill/core/browser/webdata/autofill_webdata_service.h
@@ -118,12 +118,12 @@ class AutofillWebDataService : public AutofillWebData,
// The MessageLoopProxy that this class uses as its DB thread.
scoped_refptr<base::MessageLoopProxy> db_thread_;
+ scoped_refptr<AutofillWebDataBackendImpl> autofill_backend_;
+
// This factory is used on the UI thread. All vended weak pointers are
// invalidated in ShutdownOnUIThread().
base::WeakPtrFactory<AutofillWebDataService> weak_ptr_factory_;
- scoped_refptr<AutofillWebDataBackendImpl> autofill_backend_;
-
DISALLOW_COPY_AND_ASSIGN(AutofillWebDataService);
};

Powered by Google App Engine
This is Rietveld 408576698