Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: components/policy/core/common/cloud/user_cloud_policy_store.h

Issue 554233002: Refactoring the WeakPtrFactory usage, Member variables should appear before the WeakPtrFactory, to … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/cloud/user_cloud_policy_store.h
diff --git a/components/policy/core/common/cloud/user_cloud_policy_store.h b/components/policy/core/common/cloud/user_cloud_policy_store.h
index 9610fa371cdd1486de4bc89711cca9af9e212256..ebc75e663a42d48477f0cb8d2dd227fc936f01e8 100644
--- a/components/policy/core/common/cloud/user_cloud_policy_store.h
+++ b/components/policy/core/common/cloud/user_cloud_policy_store.h
@@ -91,9 +91,6 @@ class POLICY_EXPORT UserCloudPolicyStore : public UserCloudPolicyStoreBase {
// Callback invoked to store the policy after validation has finished.
void StorePolicyAfterValidation(UserCloudPolicyValidator* validator);
- // WeakPtrFactory used to create callbacks for validating and storing policy.
- base::WeakPtrFactory<UserCloudPolicyStore> weak_factory_;
-
// The key used to verify signatures of cached policy.
std::string policy_key_;
@@ -106,6 +103,9 @@ class POLICY_EXPORT UserCloudPolicyStore : public UserCloudPolicyStoreBase {
// The hard-coded key used to verify new signing keys.
const std::string verification_key_;
+ // WeakPtrFactory used to create callbacks for validating and storing policy.
+ base::WeakPtrFactory<UserCloudPolicyStore> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(UserCloudPolicyStore);
};

Powered by Google App Engine
This is Rietveld 408576698