Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 478433002: Avoid RenderObject::paintInvalidationForWholeRenderer() if possible (Closed)

Created:
6 years, 4 months ago by Xianzhu
Modified:
6 years, 4 months ago
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-rendering, dglazkov+blink, krit, eae+blinkwatch, ed+blinkwatch_opera.com, eric.carlson_apple.com, feature-media-reviews_chromium.org, f(malita), fs, gasubic, gyuyoung.kim_webkit.org, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr., philipj_slow, rwlbuis, rune+blink, Stephen Chennney, sof, nessy, vcarbune.chromium, zoltan1
Project:
blink
Visibility:
Public.

Description

Avoid RenderObject::paintInvalidationForWholeRenderer() if possible RenderObject::paintInvalidationForWholeRenderer() violates the principle of RAL and should be avoided if possible. - Make the method private and rename to invalidatePaintForWholeRenderer() - The only remaining caller is RenderObjectChildList::removeChildNode() - Changed other callers to use setShouldDoFullPaintInvalidation(true) - In case that shouldDoFullPaintInvalidation(true) is called not during FrameView::updateLayoutAndStyleForPainting(), schedule a visual update for the page to trigger the next frame if needed. BUG=385174 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180496

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase and update TestExpectations #

Patch Set 4 : TestExpectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -67 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
M Source/core/dom/DocumentMarkerController.cpp View 1 2 7 chunks +7 lines, -7 lines 0 comments Download
M Source/core/editing/InputMethodController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLCanvasElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormControlElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLOptionElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/FileInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/MediaControlElementTypes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/MediaControls.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/SpinButtonElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/ImageQualityController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderFileUploadControl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderImageResource.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/rendering/RenderInline.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 2 1 chunk +1 line, -6 lines 0 comments Download
M Source/core/rendering/RenderLayerFilterInfo.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderListMarker.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderMeter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderObject.h View 1 2 3 chunks +5 lines, -11 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 2 2 chunks +12 lines, -1 line 0 comments Download
M Source/core/rendering/RenderObjectChildList.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderProgress.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderTableCol.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTableRow.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTableSection.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTextControlSingleLine.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTheme.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderView.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderWidget.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGImage.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceContainer.cpp View 1 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Xianzhu
Ran layout tests locally and found no over or under repaints. Some duplicated repaint rects ...
6 years, 4 months ago (2014-08-14 19:08:52 UTC) #1
dsinclair
lgtm
6 years, 4 months ago (2014-08-14 19:44:40 UTC) #2
robwu
Nitpick: The commit message has a typo (violets -> violates).
6 years, 4 months ago (2014-08-15 22:52:19 UTC) #3
Xianzhu
On 2014/08/15 22:52:19, robwu wrote: > Nitpick: The commit message has a typo (violets -> ...
6 years, 4 months ago (2014-08-18 15:31:05 UTC) #4
Julien - ping for review
lgtm but we should test some navigation with Chromium before landing (I am afraid about ...
6 years, 4 months ago (2014-08-18 16:51:11 UTC) #5
Xianzhu
On 2014/08/18 16:51:11, Julien Chaffraix - PST wrote: > lgtm but we should test some ...
6 years, 4 months ago (2014-08-18 17:48:08 UTC) #6
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 4 months ago (2014-08-18 17:48:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/478433002/40001
6 years, 4 months ago (2014-08-18 17:50:02 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-18 18:53:08 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-18 19:18:55 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/21142)
6 years, 4 months ago (2014-08-18 19:18:58 UTC) #11
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 4 months ago (2014-08-18 20:26:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/478433002/60001
6 years, 4 months ago (2014-08-18 20:27:06 UTC) #13
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 21:35:14 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (60001) as 180496

Powered by Google App Engine
This is Rietveld 408576698