Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Side by Side Diff: Source/core/html/forms/FileInputType.cpp

Issue 478433002: Avoid RenderObject::paintInvalidationForWholeRenderer() if possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: TestExpectations Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
3 * Copyright (C) 2010 Google Inc. All rights reserved. 3 * Copyright (C) 2010 Google Inc. All rights reserved.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 286 matching lines...) Expand 10 before | Expand all | Expand 10 after
297 } 297 }
298 } 298 }
299 } 299 }
300 300
301 m_fileList = files; 301 m_fileList = files;
302 302
303 input->notifyFormStateChanged(); 303 input->notifyFormStateChanged();
304 input->setNeedsValidityCheck(); 304 input->setNeedsValidityCheck();
305 305
306 if (input->renderer()) 306 if (input->renderer())
307 input->renderer()->paintInvalidationForWholeRenderer(); 307 input->renderer()->setShouldDoFullPaintInvalidation(true);
308 308
309 if (pathsChanged) { 309 if (pathsChanged) {
310 // This call may cause destruction of this instance. 310 // This call may cause destruction of this instance.
311 // input instance is safe since it is ref-counted. 311 // input instance is safe since it is ref-counted.
312 input->dispatchChangeEvent(); 312 input->dispatchChangeEvent();
313 } 313 }
314 input->setChangedSinceLastFormControlChangeEvent(false); 314 input->setChangedSinceLastFormControlChangeEvent(false);
315 } 315 }
316 316
317 void FileInputType::filesChosen(const Vector<FileChooserFileInfo>& files) 317 void FileInputType::filesChosen(const Vector<FileChooserFileInfo>& files)
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
378 StringBuilder names; 378 StringBuilder names;
379 for (size_t i = 0; i < listSize; ++i) { 379 for (size_t i = 0; i < listSize; ++i) {
380 names.append(fileList->item(i)->name()); 380 names.append(fileList->item(i)->name());
381 if (i != listSize - 1) 381 if (i != listSize - 1)
382 names.append('\n'); 382 names.append('\n');
383 } 383 }
384 return names.toString(); 384 return names.toString();
385 } 385 }
386 386
387 } // namespace blink 387 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/html/HTMLOptionElement.cpp ('k') | Source/core/html/shadow/MediaControlElementTypes.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698