Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Side by Side Diff: Source/core/rendering/RenderWidget.cpp

Issue 478433002: Avoid RenderObject::paintInvalidationForWholeRenderer() if possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: TestExpectations Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderView.cpp ('k') | Source/core/rendering/svg/RenderSVGImage.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2000 Dirk Mueller (mueller@kde.org) 3 * Copyright (C) 2000 Dirk Mueller (mueller@kde.org)
4 * Copyright (C) 2004, 2006, 2009, 2010 Apple Inc. All rights reserved. 4 * Copyright (C) 2004, 2006, 2009, 2010 Apple Inc. All rights reserved.
5 * Copyright (C) 2013 Google Inc. All rights reserved. 5 * Copyright (C) 2013 Google Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 252 matching lines...) Expand 10 before | Expand all | Expand 10 after
263 return; 263 return;
264 264
265 if (!needsLayout()) 265 if (!needsLayout())
266 updateWidgetGeometry(); 266 updateWidgetGeometry();
267 267
268 if (style()->visibility() != VISIBLE) { 268 if (style()->visibility() != VISIBLE) {
269 widget->hide(); 269 widget->hide();
270 } else { 270 } else {
271 widget->show(); 271 widget->show();
272 // FIXME: Why do we issue a full paint invalidation in this case, but no t the other? 272 // FIXME: Why do we issue a full paint invalidation in this case, but no t the other?
273 paintInvalidationForWholeRenderer(); 273 setShouldDoFullPaintInvalidation(true);
274 } 274 }
275 } 275 }
276 276
277 void RenderWidget::updateWidgetPosition() 277 void RenderWidget::updateWidgetPosition()
278 { 278 {
279 Widget* widget = this->widget(); 279 Widget* widget = this->widget();
280 if (!widget || !node()) // Check the node in case destroy() has been called. 280 if (!widget || !node()) // Check the node in case destroy() has been called.
281 return; 281 return;
282 282
283 bool boundsChanged = updateWidgetGeometry(); 283 bool boundsChanged = updateWidgetGeometry();
(...skipping 30 matching lines...) Expand all
314 CursorDirective RenderWidget::getCursor(const LayoutPoint& point, Cursor& cursor ) const 314 CursorDirective RenderWidget::getCursor(const LayoutPoint& point, Cursor& cursor ) const
315 { 315 {
316 if (widget() && widget()->isPluginView()) { 316 if (widget() && widget()->isPluginView()) {
317 // A plug-in is responsible for setting the cursor when the pointer is o ver it. 317 // A plug-in is responsible for setting the cursor when the pointer is o ver it.
318 return DoNotSetCursor; 318 return DoNotSetCursor;
319 } 319 }
320 return RenderReplaced::getCursor(point, cursor); 320 return RenderReplaced::getCursor(point, cursor);
321 } 321 }
322 322
323 } // namespace blink 323 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderView.cpp ('k') | Source/core/rendering/svg/RenderSVGImage.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698