Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: Source/core/html/shadow/SpinButtonElement.cpp

Issue 478433002: Avoid RenderObject::paintInvalidationForWholeRenderer() if possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: TestExpectations Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2008, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2008, 2010 Apple Inc. All rights reserved.
3 * Copyright (C) 2010 Google Inc. All rights reserved. 3 * Copyright (C) 2010 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 if (LocalFrame* frame = document().frame()) { 118 if (LocalFrame* frame = document().frame()) {
119 frame->eventHandler().setCapturingMouseEventsNode(this); 119 frame->eventHandler().setCapturingMouseEventsNode(this);
120 m_capturing = true; 120 m_capturing = true;
121 if (Page* page = document().page()) 121 if (Page* page = document().page())
122 page->chrome().registerPopupOpeningObserver(this); 122 page->chrome().registerPopupOpeningObserver(this);
123 } 123 }
124 } 124 }
125 UpDownState oldUpDownState = m_upDownState; 125 UpDownState oldUpDownState = m_upDownState;
126 m_upDownState = (local.y() < box->height() / 2) ? Up : Down; 126 m_upDownState = (local.y() < box->height() / 2) ? Up : Down;
127 if (m_upDownState != oldUpDownState) 127 if (m_upDownState != oldUpDownState)
128 renderer()->paintInvalidationForWholeRenderer(); 128 renderer()->setShouldDoFullPaintInvalidation(true);
129 } else { 129 } else {
130 releaseCapture(); 130 releaseCapture();
131 m_upDownState = Indeterminate; 131 m_upDownState = Indeterminate;
132 } 132 }
133 } 133 }
134 134
135 if (!event->defaultHandled()) 135 if (!event->defaultHandled())
136 HTMLDivElement::defaultEventHandler(event); 136 HTMLDivElement::defaultEventHandler(event);
137 } 137 }
138 138
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
257 return !m_spinButtonOwner || m_spinButtonOwner->shouldSpinButtonRespondToMou seEvents(); 257 return !m_spinButtonOwner || m_spinButtonOwner->shouldSpinButtonRespondToMou seEvents();
258 } 258 }
259 259
260 void SpinButtonElement::trace(Visitor* visitor) 260 void SpinButtonElement::trace(Visitor* visitor)
261 { 261 {
262 visitor->trace(m_spinButtonOwner); 262 visitor->trace(m_spinButtonOwner);
263 HTMLDivElement::trace(visitor); 263 HTMLDivElement::trace(visitor);
264 } 264 }
265 265
266 } 266 }
OLDNEW
« no previous file with comments | « Source/core/html/shadow/MediaControls.cpp ('k') | Source/core/rendering/ImageQualityController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698