Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Side by Side Diff: Source/core/rendering/RenderFileUploadControl.cpp

Issue 478433002: Avoid RenderObject::paintInvalidationForWholeRenderer() if possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: TestExpectations Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderBox.cpp ('k') | Source/core/rendering/RenderImageResource.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 m_canReceiveDroppedFiles = newCanReceiveDroppedFilesState; 66 m_canReceiveDroppedFiles = newCanReceiveDroppedFilesState;
67 button->setActive(newCanReceiveDroppedFilesState); 67 button->setActive(newCanReceiveDroppedFilesState);
68 } 68 }
69 } 69 }
70 70
71 // This only supports clearing out the files, but that's OK because for 71 // This only supports clearing out the files, but that's OK because for
72 // security reasons that's the only change the DOM is allowed to make. 72 // security reasons that's the only change the DOM is allowed to make.
73 FileList* files = input->files(); 73 FileList* files = input->files();
74 ASSERT(files); 74 ASSERT(files);
75 if (files && files->isEmpty()) 75 if (files && files->isEmpty())
76 paintInvalidationForWholeRenderer(); 76 setShouldDoFullPaintInvalidation(true);
77 } 77 }
78 78
79 static int nodeWidth(Node* node) 79 static int nodeWidth(Node* node)
80 { 80 {
81 return (node && node->renderBox()) ? node->renderBox()->pixelSnappedWidth() : 0; 81 return (node && node->renderBox()) ? node->renderBox()->pixelSnappedWidth() : 0;
82 } 82 }
83 83
84 int RenderFileUploadControl::maxFilenameWidth() const 84 int RenderFileUploadControl::maxFilenameWidth() const
85 { 85 {
86 return std::max(0, contentBoxRect().pixelSnappedWidth() - nodeWidth(uploadBu tton()) - afterButtonSpacing); 86 return std::max(0, contentBoxRect().pixelSnappedWidth() - nodeWidth(uploadBu tton()) - afterButtonSpacing);
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
218 } 218 }
219 219
220 String RenderFileUploadControl::fileTextValue() const 220 String RenderFileUploadControl::fileTextValue() const
221 { 221 {
222 HTMLInputElement* input = toHTMLInputElement(node()); 222 HTMLInputElement* input = toHTMLInputElement(node());
223 ASSERT(input->files()); 223 ASSERT(input->files());
224 return RenderTheme::theme().fileListNameForWidth(input->locale(), input->fil es(), style()->font(), maxFilenameWidth()); 224 return RenderTheme::theme().fileListNameForWidth(input->locale(), input->fil es(), style()->font(), maxFilenameWidth());
225 } 225 }
226 226
227 } // namespace blink 227 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderBox.cpp ('k') | Source/core/rendering/RenderImageResource.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698