Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: Source/core/rendering/RenderTheme.cpp

Issue 478433002: Avoid RenderObject::paintInvalidationForWholeRenderer() if possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: TestExpectations Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /** 1 /**
2 * This file is part of the theme implementation for form controls in WebCore. 2 * This file is part of the theme implementation for form controls in WebCore.
3 * 3 *
4 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Computer, Inc. 4 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Computer, Inc.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 613 matching lines...) Expand 10 before | Expand all | Expand 10 after
624 bool RenderTheme::stateChanged(RenderObject* o, ControlState state) const 624 bool RenderTheme::stateChanged(RenderObject* o, ControlState state) const
625 { 625 {
626 // Default implementation assumes the controls don't respond to changes in : hover state 626 // Default implementation assumes the controls don't respond to changes in : hover state
627 if (state == HoverControlState && !supportsHover(o->style())) 627 if (state == HoverControlState && !supportsHover(o->style()))
628 return false; 628 return false;
629 629
630 // Assume pressed state is only responded to if the control is enabled. 630 // Assume pressed state is only responded to if the control is enabled.
631 if (state == PressedControlState && !isEnabled(o)) 631 if (state == PressedControlState && !isEnabled(o))
632 return false; 632 return false;
633 633
634 o->paintInvalidationForWholeRenderer(); 634 o->setShouldDoFullPaintInvalidation(true);
635 return true; 635 return true;
636 } 636 }
637 637
638 ControlStates RenderTheme::controlStatesForRenderer(const RenderObject* o) const 638 ControlStates RenderTheme::controlStatesForRenderer(const RenderObject* o) const
639 { 639 {
640 ControlStates result = 0; 640 ControlStates result = 0;
641 if (isHovered(o)) { 641 if (isHovered(o)) {
642 result |= HoverControlState; 642 result |= HoverControlState;
643 if (isSpinUpButtonPartHovered(o)) 643 if (isSpinUpButtonPartHovered(o))
644 result |= SpinUpControlState; 644 result |= SpinUpControlState;
(...skipping 561 matching lines...) Expand 10 before | Expand all | Expand 10 after
1206 1206
1207 // padding - not honored by WinIE, needs to be removed. 1207 // padding - not honored by WinIE, needs to be removed.
1208 style->resetPadding(); 1208 style->resetPadding();
1209 1209
1210 // border - honored by WinIE, but looks terrible (just paints in the control box and turns off the Windows XP theme) 1210 // border - honored by WinIE, but looks terrible (just paints in the control box and turns off the Windows XP theme)
1211 // for now, we will not honor it. 1211 // for now, we will not honor it.
1212 style->resetBorder(); 1212 style->resetBorder();
1213 } 1213 }
1214 1214
1215 } // namespace blink 1215 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderTextControlSingleLine.cpp ('k') | Source/core/rendering/RenderView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698