Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: Source/core/html/HTMLOptionElement.cpp

Issue 478433002: Avoid RenderObject::paintInvalidationForWholeRenderer() if possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: TestExpectations Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/HTMLMediaElement.cpp ('k') | Source/core/html/forms/FileInputType.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 5 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
6 * Copyright (C) 2004, 2005, 2006, 2010 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2010 Apple Inc. All rights reserved.
7 * Copyright (C) 2010 Google Inc. All rights reserved. 7 * Copyright (C) 2010 Google Inc. All rights reserved.
8 * Copyright (C) 2011 Motorola Mobility, Inc. All rights reserved. 8 * Copyright (C) 2011 Motorola Mobility, Inc. All rights reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 291 matching lines...) Expand 10 before | Expand all | Expand 10 after
302 } 302 }
303 303
304 void HTMLOptionElement::didRecalcStyle(StyleRecalcChange change) 304 void HTMLOptionElement::didRecalcStyle(StyleRecalcChange change)
305 { 305 {
306 if (change == NoChange) 306 if (change == NoChange)
307 return; 307 return;
308 308
309 // FIXME: We ask our owner select to repaint regardless of which property ch anged. 309 // FIXME: We ask our owner select to repaint regardless of which property ch anged.
310 if (HTMLSelectElement* select = ownerSelectElement()) { 310 if (HTMLSelectElement* select = ownerSelectElement()) {
311 if (RenderObject* renderer = select->renderer()) 311 if (RenderObject* renderer = select->renderer())
312 renderer->paintInvalidationForWholeRenderer(); 312 renderer->setShouldDoFullPaintInvalidation(true);
313 } 313 }
314 } 314 }
315 315
316 String HTMLOptionElement::textIndentedToRespectGroupLabel() const 316 String HTMLOptionElement::textIndentedToRespectGroupLabel() const
317 { 317 {
318 ContainerNode* parent = parentNode(); 318 ContainerNode* parent = parentNode();
319 if (parent && isHTMLOptGroupElement(*parent)) 319 if (parent && isHTMLOptGroupElement(*parent))
320 return " " + text(); 320 return " " + text();
321 return text(); 321 return text();
322 } 322 }
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
409 ASSERT(parent); 409 ASSERT(parent);
410 if (isHTMLOptGroupElement(*parent)) { 410 if (isHTMLOptGroupElement(*parent)) {
411 RenderStyle* parentStyle = parent->renderStyle() ? parent->renderSty le() : parent->computedStyle(); 411 RenderStyle* parentStyle = parent->renderStyle() ? parent->renderSty le() : parent->computedStyle();
412 return !parentStyle || parentStyle->display() == NONE; 412 return !parentStyle || parentStyle->display() == NONE;
413 } 413 }
414 } 414 }
415 return m_style->display() == NONE; 415 return m_style->display() == NONE;
416 } 416 }
417 417
418 } // namespace blink 418 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/html/HTMLMediaElement.cpp ('k') | Source/core/html/forms/FileInputType.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698