Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: Source/core/html/shadow/MediaControls.cpp

Issue 478433002: Avoid RenderObject::paintInvalidationForWholeRenderer() if possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: TestExpectations Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 3 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 302 matching lines...) Expand 10 before | Expand all | Expand 10 after
313 313
314 // Allow the theme to format the time. 314 // Allow the theme to format the time.
315 m_currentTimeDisplay->setInnerText(RenderTheme::theme().formatMediaControlsC urrentTime(now, duration), IGNORE_EXCEPTION); 315 m_currentTimeDisplay->setInnerText(RenderTheme::theme().formatMediaControlsC urrentTime(now, duration), IGNORE_EXCEPTION);
316 m_currentTimeDisplay->setCurrentValue(now); 316 m_currentTimeDisplay->setCurrentValue(now);
317 } 317 }
318 318
319 void MediaControls::updateVolume() 319 void MediaControls::updateVolume()
320 { 320 {
321 m_muteButton->updateDisplayType(); 321 m_muteButton->updateDisplayType();
322 if (m_muteButton->renderer()) 322 if (m_muteButton->renderer())
323 m_muteButton->renderer()->paintInvalidationForWholeRenderer(); 323 m_muteButton->renderer()->setShouldDoFullPaintInvalidation(true);
324 324
325 if (mediaElement().muted()) 325 if (mediaElement().muted())
326 m_volumeSlider->setVolume(0); 326 m_volumeSlider->setVolume(0);
327 else 327 else
328 m_volumeSlider->setVolume(mediaElement().volume()); 328 m_volumeSlider->setVolume(mediaElement().volume());
329 } 329 }
330 330
331 void MediaControls::changedClosedCaptionsVisibility() 331 void MediaControls::changedClosedCaptionsVisibility()
332 { 332 {
333 m_toggleClosedCaptionsButton->updateDisplayType(); 333 m_toggleClosedCaptionsButton->updateDisplayType();
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
481 visitor->trace(m_muteButton); 481 visitor->trace(m_muteButton);
482 visitor->trace(m_volumeSlider); 482 visitor->trace(m_volumeSlider);
483 visitor->trace(m_toggleClosedCaptionsButton); 483 visitor->trace(m_toggleClosedCaptionsButton);
484 visitor->trace(m_fullScreenButton); 484 visitor->trace(m_fullScreenButton);
485 visitor->trace(m_durationDisplay); 485 visitor->trace(m_durationDisplay);
486 visitor->trace(m_enclosure); 486 visitor->trace(m_enclosure);
487 HTMLDivElement::trace(visitor); 487 HTMLDivElement::trace(visitor);
488 } 488 }
489 489
490 } 490 }
OLDNEW
« no previous file with comments | « Source/core/html/shadow/MediaControlElementTypes.cpp ('k') | Source/core/html/shadow/SpinButtonElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698