Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: Source/core/dom/DocumentMarkerController.cpp

Issue 478433002: Avoid RenderObject::paintInvalidationForWholeRenderer() if possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: TestExpectations Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/TestExpectations ('k') | Source/core/editing/InputMethodController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/DocumentMarkerController.cpp
diff --git a/Source/core/dom/DocumentMarkerController.cpp b/Source/core/dom/DocumentMarkerController.cpp
index a66c1a7c2a0ae131afe2135d78d41ced221e668f..95fb913cee71c1b99265d4be21902086356778d9 100644
--- a/Source/core/dom/DocumentMarkerController.cpp
+++ b/Source/core/dom/DocumentMarkerController.cpp
@@ -228,7 +228,7 @@ void DocumentMarkerController::addMarker(Node* node, const DocumentMarker& newMa
// repaint the affected node
if (node->renderer())
- node->renderer()->paintInvalidationForWholeRenderer();
+ node->renderer()->setShouldDoFullPaintInvalidation(true);
}
void DocumentMarkerController::mergeOverlapping(MarkerList* list, DocumentMarker& toInsert)
@@ -289,7 +289,7 @@ void DocumentMarkerController::copyMarkers(Node* srcNode, unsigned startOffset,
// repaint the affected node
if (docDirty && dstNode->renderer())
- dstNode->renderer()->paintInvalidationForWholeRenderer();
+ dstNode->renderer()->setShouldDoFullPaintInvalidation(true);
}
void DocumentMarkerController::removeMarkers(Node* node, unsigned startOffset, int length, DocumentMarker::MarkerTypes markerTypes, RemovePartiallyOverlappingMarkerOrNot shouldRemovePartiallyOverlappingMarker)
@@ -370,7 +370,7 @@ void DocumentMarkerController::removeMarkers(Node* node, unsigned startOffset, i
// repaint the affected node
if (docDirty && node->renderer())
- node->renderer()->paintInvalidationForWholeRenderer();
+ node->renderer()->setShouldDoFullPaintInvalidation(true);
}
DocumentMarker* DocumentMarkerController::markerContainingPoint(const LayoutPoint& point, DocumentMarker::MarkerType markerType)
@@ -579,7 +579,7 @@ void DocumentMarkerController::removeMarkersFromList(MarkerMap::iterator iterato
if (needsRepainting) {
if (RenderObject* renderer = iterator->key->renderer())
- renderer->paintInvalidationForWholeRenderer();
+ renderer->setShouldDoFullPaintInvalidation(true);
}
if (nodeCanBeRemoved) {
@@ -609,7 +609,7 @@ void DocumentMarkerController::repaintMarkers(DocumentMarker::MarkerTypes marker
// cause the node to be redrawn
if (RenderObject* renderer = node->renderer()) {
- renderer->paintInvalidationForWholeRenderer();
+ renderer->setShouldDoFullPaintInvalidation(true);
break;
}
}
@@ -663,7 +663,7 @@ void DocumentMarkerController::shiftMarkers(Node* node, unsigned startOffset, in
// repaint the affected node
if (docDirty && node->renderer())
- node->renderer()->paintInvalidationForWholeRenderer();
+ node->renderer()->setShouldDoFullPaintInvalidation(true);
}
void DocumentMarkerController::setMarkersActive(Range* range, bool active)
@@ -707,7 +707,7 @@ void DocumentMarkerController::setMarkersActive(Node* node, unsigned startOffset
// repaint the affected node
if (docDirty && node->renderer())
- node->renderer()->paintInvalidationForWholeRenderer();
+ node->renderer()->setShouldDoFullPaintInvalidation(true);
}
bool DocumentMarkerController::hasMarkers(Range* range, DocumentMarker::MarkerTypes markerTypes)
« no previous file with comments | « LayoutTests/TestExpectations ('k') | Source/core/editing/InputMethodController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698