Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: Source/core/rendering/RenderTableSection.cpp

Issue 478433002: Avoid RenderObject::paintInvalidationForWholeRenderer() if possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: TestExpectations Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010, 2013 Apple Inc. All r ights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010, 2013 Apple Inc. All r ights reserved.
8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1519 matching lines...) Expand 10 before | Expand all | Expand 10 after
1530 for (unsigned i = 0; i < cells.size(); ++i) 1530 for (unsigned i = 0; i < cells.size(); ++i)
1531 paintCell(cells[i], paintInfo, paintOffset); 1531 paintCell(cells[i], paintInfo, paintOffset);
1532 } 1532 }
1533 } 1533 }
1534 } 1534 }
1535 } 1535 }
1536 1536
1537 void RenderTableSection::imageChanged(WrappedImagePtr, const IntRect*) 1537 void RenderTableSection::imageChanged(WrappedImagePtr, const IntRect*)
1538 { 1538 {
1539 // FIXME: Examine cells and issue paint invalidations of only the rect the i mage paints in. 1539 // FIXME: Examine cells and issue paint invalidations of only the rect the i mage paints in.
1540 paintInvalidationForWholeRenderer(); 1540 setShouldDoFullPaintInvalidation(true);
1541 } 1541 }
1542 1542
1543 void RenderTableSection::recalcCells() 1543 void RenderTableSection::recalcCells()
1544 { 1544 {
1545 ASSERT(m_needsCellRecalc); 1545 ASSERT(m_needsCellRecalc);
1546 // We reset the flag here to ensure that |addCell| works. This is safe to do as 1546 // We reset the flag here to ensure that |addCell| works. This is safe to do as
1547 // fillRowsWithDefaultStartingAtPosition makes sure we match the table's col umns 1547 // fillRowsWithDefaultStartingAtPosition makes sure we match the table's col umns
1548 // representation. 1548 // representation.
1549 m_needsCellRecalc = false; 1549 m_needsCellRecalc = false;
1550 1550
(...skipping 218 matching lines...) Expand 10 before | Expand all | Expand 10 after
1769 // FIXME: The table's direction should determine our row's direction, not th e section's (see bug 96691). 1769 // FIXME: The table's direction should determine our row's direction, not th e section's (see bug 96691).
1770 if (!style()->isLeftToRightDirection()) 1770 if (!style()->isLeftToRightDirection())
1771 cellLocation.setX(table()->columnPositions()[table()->numEffCols()] - ta ble()->columnPositions()[table()->colToEffCol(cell->col() + cell->colSpan())] + horizontalBorderSpacing); 1771 cellLocation.setX(table()->columnPositions()[table()->numEffCols()] - ta ble()->columnPositions()[table()->colToEffCol(cell->col() + cell->colSpan())] + horizontalBorderSpacing);
1772 else 1772 else
1773 cellLocation.setX(table()->columnPositions()[effectiveColumn] + horizont alBorderSpacing); 1773 cellLocation.setX(table()->columnPositions()[effectiveColumn] + horizont alBorderSpacing);
1774 1774
1775 cell->setLogicalLocation(cellLocation); 1775 cell->setLogicalLocation(cellLocation);
1776 } 1776 }
1777 1777
1778 } // namespace blink 1778 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderTableRow.cpp ('k') | Source/core/rendering/RenderTextControlSingleLine.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698