Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2944843002: All strong mode cleaning of dart2js. (Closed)

Created:
3 years, 6 months ago by ahe
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

All strong mode cleaning of dart2js. Fixes https://github.com/dart-lang/sdk/issues/29886 Supersedes CLs 2939193003, 2950433002, and 2947583002. R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/69d6e8e55a41b70549d7755a4b6b39b947526c8f

Patch Set 1 : CLs 2939193003, 2950433002, and 2947583002. #

Patch Set 2 : Fixes for various issues found during testing. #

Patch Set 3 : Additional fixes for issues found during testing. #

Patch Set 4 : More issues discovered during testing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1992 lines, -1840 lines) Patch
M pkg/compiler/analysis_options.yaml View 1 chunk +0 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/closure.dart View 6 chunks +9 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/constants/constant_constructors.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/constants/constructors.dart View 1 chunk +8 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/constants/evaluation.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/constants/values.dart View 1 chunk +16 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/dump_info.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/elements/common.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/jumps.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 2 3 26 chunks +106 lines, -46 lines 0 comments Download
M pkg/compiler/lib/src/elements/resolution_types.dart View 1 2 3 30 chunks +86 lines, -66 lines 0 comments Download
M pkg/compiler/lib/src/elements/types.dart View 1 2 3 13 chunks +57 lines, -52 lines 0 comments Download
M pkg/compiler/lib/src/elements/visitor.dart View 1 chunk +98 lines, -63 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/helpers/expensive_map.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/helpers/helpers.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/helpers/track_map.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/builder.dart View 23 chunks +39 lines, -60 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/locals_handler.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/node_tracer.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 6 chunks +14 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/io/source_information.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js/rewrite_async.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_serialization.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_emitter.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_system_javascript.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/element_strategy.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/field_naming_mixin.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/frequency_namer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/minify_namer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/mirrors_analysis.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/mirrors_data.dart View 4 chunks +8 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer_names.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/no_such_method_registry.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 6 chunks +9 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 3 chunks +6 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 2 chunks +2 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart View 2 chunks +4 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/metadata_collector.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 1 chunk +8 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/type_test_registry.dart View 3 chunks +9 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_model/elements.dart View 4 chunks +6 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map.dart View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 8 chunks +14 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_visitor.dart View 11 chunks +12 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/kernel/types.dart View 1 3 chunks +6 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/kernel/unresolved.dart View 24 chunks +48 lines, -40 lines 0 comments Download
M pkg/compiler/lib/src/native/resolver.dart View 5 chunks +10 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/ordered_typeset.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/parser/partial_elements.dart View 3 chunks +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_members.dart View 3 chunks +6 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/enum_creator.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/member_impl.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_common.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_strategy.dart View 18 chunks +40 lines, -36 lines 0 comments Download
M pkg/compiler/lib/src/resolution/scope.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 117 chunks +148 lines, -149 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart View 196 chunks +509 lines, -512 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/signatures.dart View 1 8 chunks +9 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/resolution/tree_elements.dart View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/type_resolver.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/element_serialization.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 76 chunks +206 lines, -168 lines 0 comments Download
M pkg/compiler/lib/src/serialization/json_serializer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 2 3 33 chunks +69 lines, -40 lines 0 comments Download
M pkg/compiler/lib/src/serialization/system.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/source_file_provider.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 2 3 15 chunks +35 lines, -29 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 5 chunks +10 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/ssa/rasta_ssa_builder_task.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/types/flat_type_mask.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/types/forwarding_type_mask.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/types/union_type_mask.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/universe/class_set.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/codegen_world_builder.dart View 4 chunks +8 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/universe/element_world_builder.dart View 1 2 3 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/universe/resolution_world_builder.dart View 7 chunks +16 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_builder.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/util/emptyset.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/util/maplet.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/util/setlet.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 6 chunks +18 lines, -16 lines 0 comments Download
M pkg/compiler/testing.json View 1 1 chunk +6 lines, -46 lines 0 comments Download
M pkg/compiler/tool/dart2js_profile_many.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/tool/track_memory.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/testing/lib/src/analyze.dart View 1 chunk +0 lines, -8 lines 0 comments Download
A tests/compiler/dart2js/analysis_options.yaml View 1 chunk +18 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/analyze_api_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/analyze_helper.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/analyze_test_test.dart View 2 chunks +1 line, -4 lines 0 comments Download
M tests/compiler/dart2js/bad_output_io_test.dart View 2 chunks +13 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/class_set_test.dart View 7 chunks +8 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/constant_expression_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/data/mirrors_helper.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/deferred_dont_inline_deferred_constants_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/deferred_follow_constant_dependencies_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/deferred_follow_implicit_super_regression_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/deferred_load_graph_segmentation_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/deferred_mirrors_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/deferred_not_in_main_test.dart View 2 chunks +4 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/diagnostic_helper.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/diagnostic_reporter_helper.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/embedded_category_api_boundary_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/equivalence/check_helpers.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/exit_code_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/gvn_dynamic_field_get_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world2_test.dart View 2 chunks +1 line, -2 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_from_dill_test.dart View 2 chunks +1 line, -2 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 2 chunks +1 line, -11 lines 0 comments Download
M tests/compiler/dart2js/kernel/compile_from_dill_test.dart View 3 chunks +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/members_test.dart View 5 chunks +0 lines, -12 lines 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/metadata_test.dart View 3 chunks +7 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/mirror_private_name_inheritance_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/mixin_typevariable_test.dart View 3 chunks +1 line, -7 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/parser_helper.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/quarantined/http_test.dart View 2 chunks +6 lines, -1 line 0 comments Download
M tests/compiler/dart2js/related_types_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 3 chunks +0 lines, -8 lines 0 comments Download
M tests/compiler/dart2js/serialization/duplicate_library_test.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/serialization/members_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/serialization/test_helper.dart View 1 chunk +0 lines, -14 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_const_closure_default_test.dart View 2 chunks +1 line, -11 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/source_map_validator_helper.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/sourcemaps/data/invokes_test_file.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/sourcemaps/diff_view.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/sourcemaps/mapping_test.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/sourcemaps/nomapping_test.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/sourcemaps/output_structure.dart View 3 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/sourcemaps/sourcemap_html_helper.dart View 3 chunks +12 lines, -11 lines 0 comments Download
M tests/compiler/dart2js/type_combination_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/type_equals_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/type_inference7_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/type_inference8_test.dart View 3 chunks +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/type_mask2_test.dart View 3 chunks +4 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/type_mask_disjoint_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_mask_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/type_representation_test.dart View 5 chunks +17 lines, -15 lines 0 comments Download
M tests/compiler/dart2js/type_substitution_test.dart View 3 chunks +2 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/type_test_helper.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/unparser2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A tests/utils/analysis_options.yaml View 1 1 chunk +17 lines, -0 lines 0 comments Download
M tests/utils/dart2js_test.dart View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ahe
Patch set 1 corresponds to CLs 2939193003, 2950433002, and 2947583002 which have already been reviewed.
3 years, 6 months ago (2017-06-19 10:04:26 UTC) #2
Johnni Winther
lgtm
3 years, 6 months ago (2017-06-19 10:35:42 UTC) #3
Johnni Winther
Ship it!
3 years, 6 months ago (2017-06-19 11:25:57 UTC) #4
ahe
3 years, 6 months ago (2017-06-19 12:06:47 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
69d6e8e55a41b70549d7755a4b6b39b947526c8f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698