Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: pkg/compiler/lib/src/js_backend/namer.dart

Issue 2944843002: All strong mode cleaning of dart2js. (Closed)
Patch Set: More issues discovered during testing. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_backend/mirrors_data.dart ('k') | pkg/compiler/lib/src/js_backend/namer_names.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/namer.dart
diff --git a/pkg/compiler/lib/src/js_backend/namer.dart b/pkg/compiler/lib/src/js_backend/namer.dart
index 15751cfe3a2151b13cfdc64b33968b6d889e757c..4b109ed853eeb8fdcf1afe783cb46412bd51fadb 100644
--- a/pkg/compiler/lib/src/js_backend/namer.dart
+++ b/pkg/compiler/lib/src/js_backend/namer.dart
@@ -1884,7 +1884,7 @@ class ConstantNamingVisitor implements ConstantValueVisitor {
}
@override
- void visitMap(JavaScriptMapConstant constant, [_]) {
+ void visitMap(covariant JavaScriptMapConstant constant, [_]) {
// TODO(9476): Incorporate type parameters into name.
addRoot('Map');
if (constant.length == 0) {
@@ -2178,15 +2178,15 @@ class FunctionTypeNamer extends BaseResolutionDartTypeVisitor {
return sb.toString();
}
- visit(ResolutionDartType type, [_]) {
+ visit(covariant ResolutionDartType type, [_]) {
type.accept(this, null);
}
- visitType(ResolutionDartType type, _) {
+ visitType(covariant ResolutionDartType type, _) {
sb.write(type.name);
}
- visitFunctionType(ResolutionFunctionType type, _) {
+ visitFunctionType(covariant ResolutionFunctionType type, _) {
if (rtiEncoder.isSimpleFunctionType(type)) {
sb.write('args${type.parameterTypes.length}');
return;
« no previous file with comments | « pkg/compiler/lib/src/js_backend/mirrors_data.dart ('k') | pkg/compiler/lib/src/js_backend/namer_names.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698