pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart - Issue 2944843002: All strong mode cleaning of dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart

Issue 2944843002: All strong mode cleaning of dart2js. (Closed)

Patch Set: More issues discovered during testing. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart

diff --git a/pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart b/pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart

index 284146755742d255563266ccbac642cedc7e08db..b0ccafac469d7f4874a1e291a07c7352226e6191 100644

--- a/pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart

+++ b/pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart

@@ -99,7 +99,7 @@ class JavaScriptConstantTask extends ConstantCompilerTask {

// TODO(johnniwinther): Remove this when values are computed from the

// expressions.

@override

- void copyConstantValues(JavaScriptConstantTask task) {

+ void copyConstantValues(covariant JavaScriptConstantTask task) {

jsConstantCompiler.constantValueMap

.addAll(task.jsConstantCompiler.constantValueMap);

dartConstantCompiler.constantValueMap