Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1764)

Unified Diff: pkg/compiler/lib/src/universe/resolution_world_builder.dart

Issue 2944843002: All strong mode cleaning of dart2js. (Closed)
Patch Set: More issues discovered during testing. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/universe/resolution_world_builder.dart
diff --git a/pkg/compiler/lib/src/universe/resolution_world_builder.dart b/pkg/compiler/lib/src/universe/resolution_world_builder.dart
index 0b8cdeccff92ff659e8af5efa997de4db588fa44..6f06e5ab6e0920a310275271c75b0a4d38b04c50 100644
--- a/pkg/compiler/lib/src/universe/resolution_world_builder.dart
+++ b/pkg/compiler/lib/src/universe/resolution_world_builder.dart
@@ -29,7 +29,7 @@ abstract class ResolutionWorldBuilder implements WorldBuilder, OpenWorld {
/// subtypes. The latter case only contains spurious information from
/// instantiations through factory constructors and mixins.
// TODO(johnniwinther): Improve semantic precision.
- bool isImplemented(ClassEntity cls);
+ bool isImplemented(covariant ClassEntity cls);
/// Set of all fields that are statically known to be written to.
Iterable<FieldEntity> get fieldSetters;
@@ -431,7 +431,7 @@ abstract class ResolutionWorldBuilderBase
return _implementedClasses.contains(cls);
}
- void registerClosurizedMember(FunctionEntity element) {
+ void registerClosurizedMember(MemberEntity element) {
closurizedMembers.add(element);
FunctionType type = _elementEnvironment.getFunctionType(element);
if (type.containsTypeVariables) {
@@ -575,7 +575,7 @@ abstract class ResolutionWorldBuilderBase
return constraints.addReceiverConstraint(mask);
}
- void registerIsCheck(DartType type) {
+ void registerIsCheck(covariant DartType type) {
isChecks.add(type);
}
@@ -654,7 +654,8 @@ abstract class ResolutionWorldBuilderBase
/// Called to create a [_ClassUsage] for [cls].
///
/// Subclasses override this to ensure needed invariants on [cls].
- _ClassUsage _createClassUsage(ClassEntity cls) => new _ClassUsage(cls);
+ _ClassUsage _createClassUsage(covariant ClassEntity cls) =>
+ new _ClassUsage(cls);
/// Return the canonical [_ClassUsage] for [cls].
_ClassUsage _getClassUsage(ClassEntity cls) {
@@ -709,8 +710,8 @@ abstract class ResolutionWorldBuilderBase
map[memberName].addAll(remaining);
}
- void _processInstantiatedClassMember(
- ClassEntity cls, MemberEntity member, MemberUsedCallback memberUsed) {
+ void _processInstantiatedClassMember(ClassEntity cls,
+ covariant MemberEntity member, MemberUsedCallback memberUsed) {
if (!member.isInstanceMember) return;
String memberName = member.name;
// The obvious thing to test here would be "member.isNative",
@@ -774,7 +775,8 @@ abstract class ResolutionWorldBuilderBase
_allTypedefs.add(typdef);
}
- void registerMixinUse(ClassEntity mixinApplication, ClassEntity mixin) {
+ void registerMixinUse(
+ covariant ClassEntity mixinApplication, covariant ClassEntity mixin) {
// TODO(johnniwinther): Add map restricted to live classes.
// We don't support patch classes as mixin.
Set<ClassEntity> users =
@@ -803,24 +805,24 @@ abstract class ResolutionWorldBuilderBase
return usage != null && usage.hasUse;
}
- bool checkClass(ClassEntity cls);
- bool validateClass(ClassEntity cls);
+ bool checkClass(covariant ClassEntity cls);
+ bool validateClass(covariant ClassEntity cls);
/// Returns the class mixed into [cls] if any.
- ClassEntity getAppliedMixin(ClassEntity cls);
+ ClassEntity getAppliedMixin(covariant ClassEntity cls);
/// Returns the hierarchy depth of [cls].
- int getHierarchyDepth(ClassEntity cls);
+ int getHierarchyDepth(covariant ClassEntity cls);
/// Returns `true` if [cls] implements `Function` either explicitly or through
/// a `call` method.
- bool implementsFunction(ClassEntity cls);
+ bool implementsFunction(covariant ClassEntity cls);
/// Returns the superclass of [cls] if any.
- ClassEntity getSuperClass(ClassEntity cls);
+ ClassEntity getSuperClass(covariant ClassEntity cls);
/// Returns all supertypes of [cls].
- Iterable<InterfaceType> getSupertypes(ClassEntity cls);
+ Iterable<InterfaceType> getSupertypes(covariant ClassEntity cls);
ClassHierarchyNode _ensureClassHierarchyNode(ClassEntity cls) {
assert(checkClass(cls));
« no previous file with comments | « pkg/compiler/lib/src/universe/element_world_builder.dart ('k') | pkg/compiler/lib/src/universe/world_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698