Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: pkg/compiler/lib/src/js_backend/namer_names.dart

Issue 2944843002: All strong mode cleaning of dart2js. (Closed)
Patch Set: More issues discovered during testing. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/namer_names.dart
diff --git a/pkg/compiler/lib/src/js_backend/namer_names.dart b/pkg/compiler/lib/src/js_backend/namer_names.dart
index d33c8694f588c116034648b1a9d813064444323a..981e3a87e35c82a00a793dd8d684ba691e34d1e3 100644
--- a/pkg/compiler/lib/src/js_backend/namer_names.dart
+++ b/pkg/compiler/lib/src/js_backend/namer_names.dart
@@ -34,7 +34,7 @@ class StringBackedName extends _NamerName {
int get hashCode => name.hashCode;
- int compareTo(_NamerName other) {
+ int compareTo(covariant _NamerName other) {
other = other._target;
if (other._kind != _kind) return other._kind - _kind;
return name.compareTo(other.name);
@@ -63,7 +63,7 @@ abstract class _PrefixedName extends _NamerName implements jsAst.AstContainer {
int get hashCode => base.hashCode * 13 + prefix.hashCode;
- int compareTo(_NamerName other) {
+ int compareTo(covariant _NamerName other) {
other = other._target;
if (other._kind != _kind) return other._kind - _kind;
_PrefixedName otherSameKind = other;
@@ -139,7 +139,7 @@ class CompoundName extends _NamerName implements jsAst.AstContainer {
return _cachedHashCode;
}
- int compareTo(_NamerName other) {
+ int compareTo(covariant _NamerName other) {
other = other._target;
if (other._kind != _kind) return other._kind - _kind;
CompoundName otherSameKind = other;
@@ -171,7 +171,7 @@ class TokenName extends _NamerName implements jsAst.ReferenceCountedAstNode {
}
@override
- int compareTo(_NamerName other) {
+ int compareTo(covariant _NamerName other) {
other = other._target;
if (other._kind != _kind) return other._kind - _kind;
TokenName otherToken = other;
@@ -212,7 +212,7 @@ class _NameReference extends _NamerName implements jsAst.AstContainer {
String get name => _target.name;
@override
- int compareTo(_NamerName other) => _target.compareTo(other);
+ int compareTo(covariant _NamerName other) => _target.compareTo(other);
@override
bool operator ==(other) => _target == other;
« no previous file with comments | « pkg/compiler/lib/src/js_backend/namer.dart ('k') | pkg/compiler/lib/src/js_backend/no_such_method_registry.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698