pkg/compiler/lib/src/deferred_load.dart - Issue 2944843002: All strong mode cleaning of dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/deferred_load.dart

Issue 2944843002: All strong mode cleaning of dart2js. (Closed)

Patch Set: More issues discovered during testing. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/deferred_load.dart

diff --git a/pkg/compiler/lib/src/deferred_load.dart b/pkg/compiler/lib/src/deferred_load.dart

index d233398127bc1fcc50a7ee289ba2a9f2067c53cd..c3c4d7acb3b91fff4d5eb6181820c105a62f12d5 100644

--- a/pkg/compiler/lib/src/deferred_load.dart

+++ b/pkg/compiler/lib/src/deferred_load.dart

@@ -70,8 +70,9 @@ class OutputUnit {

String toString() => "OutputUnit($name)";

- bool operator ==(OutputUnit other) {

- return imports.length == other.imports.length &&

+ bool operator ==(other) {

+ return other is OutputUnit &&

+ imports.length == other.imports.length &&

imports.containsAll(other.imports);

}

« no previous file with comments | « pkg/compiler/lib/src/constants/values.dart ('k') | pkg/compiler/lib/src/dump_info.dart » ('j') | no next file with comments »