Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: pkg/compiler/lib/src/js_emitter/type_test_registry.dart

Issue 2944843002: All strong mode cleaning of dart2js. (Closed)
Patch Set: More issues discovered during testing. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/type_test_registry.dart
diff --git a/pkg/compiler/lib/src/js_emitter/type_test_registry.dart b/pkg/compiler/lib/src/js_emitter/type_test_registry.dart
index 1cf8e1d51dbe91dd8d0cc6270433e01e8d6b5349..ffa540bc572d5d6e94ad37958a184c8054d31ae9 100644
--- a/pkg/compiler/lib/src/js_emitter/type_test_registry.dart
+++ b/pkg/compiler/lib/src/js_emitter/type_test_registry.dart
@@ -8,6 +8,7 @@ import '../common.dart';
import '../common_elements.dart';
import '../elements/elements.dart' show ClassElement, MethodElement;
import '../elements/entities.dart';
+import '../elements/types.dart' show DartType;
import '../elements/resolution_types.dart'
show
ResolutionDartType,
@@ -51,9 +52,11 @@ class TypeTestRegistry {
Iterable<ClassElement> get classesUsingTypeVariableTests {
if (cachedClassesUsingTypeVariableTests == null) {
cachedClassesUsingTypeVariableTests = _codegenWorldBuilder.isChecks
- .where((ResolutionDartType t) => t is ResolutionTypeVariableType)
- .map((ResolutionTypeVariableType v) => v.element.enclosingClass)
- .toList();
+ .where((DartType t) => t is ResolutionTypeVariableType)
+ .map((DartType _v) {
+ ResolutionTypeVariableType v = _v;
+ return v.element.enclosingClass;
+ }).toList();
}
return cachedClassesUsingTypeVariableTests;
}
@@ -121,7 +124,9 @@ class TypeTestRegistry {
// argument checks.
// TODO(karlklose): merge this case with 2 when unifying argument and
// object checks.
- rtiChecks.getRequiredArgumentClasses().forEach(addClassWithSuperclasses);
+ rtiChecks
+ .getRequiredArgumentClasses()
+ .forEach((e) => addClassWithSuperclasses(e));
// 2. Add classes that are referenced by substitutions in object checks and
// their superclasses.
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart ('k') | pkg/compiler/lib/src/js_model/elements.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698