Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Unified Diff: pkg/compiler/lib/src/js_backend/runtime_types.dart

Issue 2944843002: All strong mode cleaning of dart2js. (Closed)
Patch Set: More issues discovered during testing. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/runtime_types.dart
diff --git a/pkg/compiler/lib/src/js_backend/runtime_types.dart b/pkg/compiler/lib/src/js_backend/runtime_types.dart
index 9533f681a0356db7e8aba207b18eec56e8e01da5..01050c3f80d0dbd961a46c2d9d5a9a1cf343ad1c 100644
--- a/pkg/compiler/lib/src/js_backend/runtime_types.dart
+++ b/pkg/compiler/lib/src/js_backend/runtime_types.dart
@@ -237,7 +237,7 @@ class _RuntimeTypesNeed implements RuntimeTypesNeed {
this.localFunctionsNeedingRti,
this.classesUsingTypeVariableExpression);
- bool checkClass(ClassEntity cls) => true;
+ bool checkClass(covariant ClassEntity cls) => true;
bool classNeedsRti(ClassEntity cls) {
assert(checkClass(cls));
@@ -300,7 +300,7 @@ class RuntimeTypesNeedBuilderImpl extends _RuntimeTypesBase
RuntimeTypesNeedBuilderImpl(this._elementEnvironment, DartTypes types)
: super(types);
- bool checkClass(ClassEntity cls) => true;
+ bool checkClass(covariant ClassEntity cls) => true;
@override
void registerClassUsingTypeVariableExpression(ClassEntity cls) {
@@ -845,7 +845,8 @@ class RuntimeTypesEncoderImpl implements RuntimeTypesEncoder {
parameters = _elementEnvironment
.getThisType(contextClass)
.typeArguments
- .map((TypeVariableType type) {
+ .map((DartType _type) {
+ TypeVariableType type = _type;
return type.element.name;
}).toList();
}
@@ -951,7 +952,8 @@ class RuntimeTypesEncoderImpl implements RuntimeTypesEncoder {
}
}
-class TypeRepresentationGenerator implements ResolutionDartTypeVisitor {
+class TypeRepresentationGenerator
+ implements ResolutionDartTypeVisitor<dynamic, Emitter> {
final Namer namer;
OnVariableCallback onVariable;
ShouldEncodeTypedefCallback shouldEncodeTypedef;
@@ -1179,7 +1181,7 @@ class TypeCheckMapping implements TypeChecks {
}
}
-class ArgumentCollector extends ResolutionDartTypeVisitor {
+class ArgumentCollector extends ResolutionDartTypeVisitor<dynamic, bool> {
final Set<ClassEntity> classes = new Set<ClassEntity>();
collect(DartType type, {bool isTypeArgument: false}) {
@@ -1211,7 +1213,8 @@ class ArgumentCollector extends ResolutionDartTypeVisitor {
}
}
-class FunctionArgumentCollector extends ResolutionDartTypeVisitor {
+class FunctionArgumentCollector
+ extends ResolutionDartTypeVisitor<dynamic, bool> {
final Set<ClassEntity> classes = new Set<ClassEntity>();
FunctionArgumentCollector();
« no previous file with comments | « pkg/compiler/lib/src/js_backend/no_such_method_registry.dart ('k') | pkg/compiler/lib/src/js_emitter/code_emitter_task.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698