All strong mode cleaning of dart2js.

tests/compiler/dart2js/class_set_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // Test for iterators on for [SubclassNode].
 
 library class_set_test;
 
 import 'package:expect/expect.dart';
 import 'package:async_helper/async_helper.dart';
@@ skipping 73 matching lines @@
   checkClass(B, indirectlyInstantiated: true);
   checkClass(C, directlyInstantiated: true, indirectlyInstantiated: true);
   checkClass(D, directlyInstantiated: true);
   checkClass(E, directlyInstantiated: true);
   checkClass(F, directlyInstantiated: true);
   checkClass(G, directlyInstantiated: true);
 
   ClassHierarchyNodeIterator iterator;
 
   void checkState(ClassElement root,
-      {ClassElement currentNode, List<List<ClassElement>> stack}) {
+      {ClassElement currentNode, List<ClassElement> stack}) {
     ClassElement classOf(ClassHierarchyNode node) {
       return node != null ? node.cls : null;
     }
 
     List<ClassElement> classesOf(Link<ClassHierarchyNode> link) {
       if (link == null) return null;
       return link.map(classOf).toList();
     }
 
     ClassElement foundRoot = iterator.root.cls;
@@ skipping 287 matching lines @@
   ClassElement E = env.getElement("E");
   ClassElement F = env.getElement("F");
   ClassElement G = env.getElement("G");
   ClassElement H = env.getElement("H");
   ClassElement I = env.getElement("I");
   ClassElement X = env.getElement("X");
 
   void checkForEachSubclass(ClassElement cls, List<ClassElement> expected) {
     ClassSet classSet = world.getClassSet(cls);
     List<ClassElement> visited = <ClassElement>[];
-    classSet.forEachSubclass((ClassElement cls) {
+    classSet.forEachSubclass((cls) {
       visited.add(cls);
     }, ClassHierarchyNode.ALL);
 
     Expect.listEquals(
         expected,
         visited,
         "Unexpected classes on $cls.forEachSubclass:\n"
         "Actual: $visited, expected: $expected\n$classSet");
 
     visited = <ClassElement>[];
-    classSet.forEachSubclass((ClassElement cls) {
+    classSet.forEachSubclass((cls) {
       visited.add(cls);
       return IterationStep.CONTINUE;
     }, ClassHierarchyNode.ALL);
 
     Expect.listEquals(
         expected,
         visited,
         "Unexpected classes on $cls.forEachSubclass:\n"
         "Actual: $visited, expected: $expected\n$classSet");
   }
 
   checkForEachSubclass(A, [A, B, D, C, G, F, I, H, E]);
   checkForEachSubclass(B, [B, D]);
   checkForEachSubclass(C, [C, G, F, I, H, E]);
   checkForEachSubclass(D, [D]);
   checkForEachSubclass(E, [E]);
   checkForEachSubclass(F, [F, I, H]);
   checkForEachSubclass(G, [G]);
   checkForEachSubclass(H, [H]);
   checkForEachSubclass(I, [I]);
   checkForEachSubclass(X, [X]);
 
   void checkForEachSubtype(ClassElement cls, List<ClassElement> expected) {
     ClassSet classSet = world.getClassSet(cls);
     List<ClassElement> visited = <ClassElement>[];
-    classSet.forEachSubtype((ClassElement cls) {
+    classSet.forEachSubtype((cls) {
       visited.add(cls);
     }, ClassHierarchyNode.ALL);
 
     Expect.listEquals(
         expected,
         visited,
         "Unexpected classes on $cls.forEachSubtype:\n"
         "Actual: $visited, expected: $expected\n$classSet");
 
     visited = <ClassElement>[];
-    classSet.forEachSubtype((ClassElement cls) {
+    classSet.forEachSubtype((cls) {
       visited.add(cls);
       return IterationStep.CONTINUE;
     }, ClassHierarchyNode.ALL);
 
     Expect.listEquals(
         expected,
         visited,
         "Unexpected classes on $cls.forEachSubtype:\n"
         "Actual: $visited, expected: $expected\n$classSet");
   }
@@ skipping 14 matching lines @@
       List<ClassElement> skipSubclasses: const <ClassElement>[],
       bool forEachSubtype: false,
       EnumSet<Instantiation> mask}) {
     if (mask == null) {
       mask = ClassHierarchyNode.ALL;
     }
 
     ClassSet classSet = world.getClassSet(cls);
     List<ClassElement> visited = <ClassElement>[];
 
-    IterationStep visit(ClassElement cls) {
+    IterationStep visit(_cls) {
+      ClassElement cls = _cls;
       visited.add(cls);
       if (cls == stop) {
         return IterationStep.STOP;
       } else if (skipSubclasses.contains(cls)) {
         return IterationStep.SKIP_SUBCLASSES;
       }
       return IterationStep.CONTINUE;
     }
 
     if (forEachSubtype) {
@@ skipping 35 matching lines @@
   checkForEach(X, [A, D, C, G, F, I, H, E],
       forEachSubtype: true, mask: ClassHierarchyNode.EXPLICITLY_INSTANTIATED);
   checkForEach(X, [A, B, D, C, G, F, I, H, E],
       forEachSubtype: true, mask: ClassHierarchyNode.INSTANTIATED);
 
   void checkAny(ClassElement cls, List<ClassElement> expected,
       {ClassElement find, bool expectedResult, bool anySubtype: false}) {
     ClassSet classSet = world.getClassSet(cls);
     List<ClassElement> visited = <ClassElement>[];
 
-    bool visit(ClassElement cls) {
+    bool visit(cls) {
       visited.add(cls);
       return cls == find;
     }
 
     bool result;
     if (anySubtype) {
       result = classSet.anySubtype(visit, ClassHierarchyNode.ALL);
     } else {
       result = classSet.anySubclass(visit, ClassHierarchyNode.ALL);
     }
@@ skipping 24 matching lines @@
   checkAny(B, [B, D], find: D, anySubtype: true, expectedResult: true);
   checkAny(B, [B, D, F, I], find: I, anySubtype: true, expectedResult: true);
 
   checkAny(X, [X, A, B, D, C, G, F, I, H, E],
       anySubtype: true, expectedResult: false);
   checkAny(X, [X, A], find: A, anySubtype: true, expectedResult: true);
   checkAny(X, [X, A, B, D], find: D, anySubtype: true, expectedResult: true);
   checkAny(X, [X, A, B, D, C, G, F, I],
       find: I, anySubtype: true, expectedResult: true);
 }